Bug 189240 - [EME] Add the WebM initData support in ClearKey CDM
Summary: [EME] Add the WebM initData support in ClearKey CDM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 189238
Blocks:
  Show dependency tree / graph
 
Reported: 2018-09-03 03:14 PDT by Yacine Bandou
Modified: 2018-09-04 03:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2018-09-03 06:53 PDT, Yacine Bandou 		no flags Details | Formatted Diff | Diff
Patch (4.64 KB, patch)
2018-09-04 02:09 PDT, Yacine Bandou 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yacine Bandou 2018-09-03 03:14:13 PDT 
Add the "webm" initDataType support in ClearKey CDM.
Read the WebM initData by following the W3C spec https://www.w3.org/TR/eme-initdata-webm/#common-system
Comment 1 Yacine Bandou 2018-09-03 06:53:59 PDT 
Created attachment 348770 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-09-04 01:24:24 PDT 
Comment on attachment 348770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348770&action=review

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:266
> +static Ref<SharedBuffer> getKeyidFromWebMInitData(const SharedBuffer& initData)

To be coherent with the rest of the file this should be called extractKeyIdFrom... (please, mind the capital I of KeyId).
Comment 3 Yacine Bandou 2018-09-04 02:09:30 PDT 
Created attachment 348809 [details]
Patch
Comment 4 WebKit Commit Bot 2018-09-04 03:27:37 PDT 
Comment on attachment 348809 [details]
Patch

Clearing flags on attachment: 348809

Committed r235610: <https://trac.webkit.org/changeset/235610>
Comment 5 WebKit Commit Bot 2018-09-04 03:27:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-04 03:28:50 PDT 
<rdar://problem/44092389>