Bug 189232 - REGRESSION (r191336): RenderFlexibleBox::adjustChildSizeForMinAndMax crashes in std::optional<>::value()
Summary: REGRESSION (r191336): RenderFlexibleBox::adjustChildSizeForMinAndMax crashes ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-02 08:30 PDT by zalan
Modified: 2018-09-02 20:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.93 KB, patch)
2018-09-02 09:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.84 KB, patch)
2018-09-02 20:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-09-02 08:30:39 PDT 
It's not guaranteed that computeMainAxisExtentForChild() comes back with a valid value.
Comment 1 zalan 2018-09-02 08:52:15 PDT 
and since r234980, now we release assert on it.
Comment 2 zalan 2018-09-02 09:24:56 PDT 
<rdar://problem/43886373>
Comment 3 zalan 2018-09-02 09:25:19 PDT 
Created attachment 348734 [details]
Patch
Comment 4 Brent Fulgham 2018-09-02 11:24:47 PDT 
Comment on attachment 348734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348734&action=review

R=me

> Source/WebCore/ChangeLog:12
> +        ensure valid values through the virtual calls of computeIntrinsicLogicalContentHeightUsing.

What symptom should we look for if these are expected to be valid? Should we have QA keep an eye out for anything in particular?
Comment 5 zalan 2018-09-02 20:02:59 PDT 
Created attachment 348753 [details]
Patch
Comment 6 WebKit Commit Bot 2018-09-02 20:41:18 PDT 
Comment on attachment 348753 [details]
Patch

Clearing flags on attachment: 348753

Committed r235590: <https://trac.webkit.org/changeset/235590>
Comment 7 WebKit Commit Bot 2018-09-02 20:41:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-09-02 20:42:21 PDT 
<rdar://problem/44061087>