Bug 189223 - Rename FilterEffectRenderer to CSSFilter
Summary: Rename FilterEffectRenderer to CSSFilter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-01 16:45 PDT by Simon Fraser (smfr)
Modified: 2018-09-01 20:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (41.04 KB, patch)
2018-09-01 16:46 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (65.00 KB, patch)
2018-09-01 16:55 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (65.18 KB, patch)
2018-09-01 17:16 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-09-01 16:45:20 PDT 
Rename FilterEffectRenderer to CSSFilter
Comment 1 Simon Fraser (smfr) 2018-09-01 16:46:45 PDT 
Created attachment 348720 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-09-01 16:55:50 PDT 
Created attachment 348721 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-09-01 17:16:27 PDT 
Created attachment 348722 [details]
Patch
Comment 4 Sam Weinig 2018-09-01 17:41:45 PDT 
Comment on attachment 348722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348722&action=review

> Source/WebCore/ChangeLog:22
> +        * rendering/CSSFilter.cpp: Copied from Source/WebCore/rendering/FilterEffectRenderer.cpp.

Seems a little weird to have something prefixed with CSS in the rendering directory (I think all the other CSS prefixed classes/files are in the css directory). Is there a way we can avoid using CSS as the prefix?
Comment 5 Simon Fraser (smfr) 2018-09-01 17:47:03 PDT 
Yeah, I had the same thought. It could be StyleFilter.
Comment 6 Sam Weinig 2018-09-01 18:08:02 PDT 
(In reply to Simon Fraser (smfr) from comment #5)
> Yeah, I had the same thought. It could be StyleFilter.

I think of the two choices, CSSFilter is clearer.
Comment 7 WebKit Commit Bot 2018-09-01 20:04:33 PDT 
Comment on attachment 348722 [details]
Patch

Clearing flags on attachment: 348722

Committed r235586: <https://trac.webkit.org/changeset/235586>
Comment 8 WebKit Commit Bot 2018-09-01 20:04:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-09-01 20:05:20 PDT 
<rdar://problem/44039175>