RESOLVED FIXED 189223
Rename FilterEffectRenderer to CSSFilter 
https://bugs.webkit.org/show_bug.cgi?id=189223
Summary Rename FilterEffectRenderer to CSSFilter
Simon Fraser (smfr)
Reported 2018-09-01 16:45:20 PDT
Rename FilterEffectRenderer to CSSFilter
Attachments
Patch (41.04 KB, patch)
2018-09-01 16:46 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (65.00 KB, patch)
2018-09-01 16:55 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (65.18 KB, patch)
2018-09-01 17:16 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-09-01 16:46:45 PDT
Created attachment 348720 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-09-01 16:55:50 PDT
Created attachment 348721 [details] Patch
Simon Fraser (smfr)
Comment 3 2018-09-01 17:16:27 PDT
Created attachment 348722 [details] Patch
Sam Weinig
Comment 4 2018-09-01 17:41:45 PDT
Comment on attachment 348722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348722&action=review > Source/WebCore/ChangeLog:22 > + * rendering/CSSFilter.cpp: Copied from Source/WebCore/rendering/FilterEffectRenderer.cpp. Seems a little weird to have something prefixed with CSS in the rendering directory (I think all the other CSS prefixed classes/files are in the css directory). Is there a way we can avoid using CSS as the prefix?
Simon Fraser (smfr)
Comment 5 2018-09-01 17:47:03 PDT
Yeah, I had the same thought. It could be StyleFilter.
Sam Weinig
Comment 6 2018-09-01 18:08:02 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Yeah, I had the same thought. It could be StyleFilter. I think of the two choices, CSSFilter is clearer.
WebKit Commit Bot
Comment 7 2018-09-01 20:04:33 PDT
Comment on attachment 348722 [details] Patch Clearing flags on attachment: 348722 Committed r235586: <https://trac.webkit.org/changeset/235586>
WebKit Commit Bot
Comment 8 2018-09-01 20:04:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-09-01 20:05:20 PDT
<rdar://problem/44039175>
Note You need to log in before you can comment on or make changes to this bug.