Bug 18922 - Test fast/frames/viewsource-empty-attribute-value.html fails when run stand-alone
: Test fast/frames/viewsource-empty-attribute-value.html fails when run stand-a...
Status: NEW
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 523.x (Safari 3)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
: LayoutTestFailure
Depends on:
  Show dependency treegraph
Reported: 2008-05-07 03:56 PDT by David Kilzer (:ddkilzer)
Modified: 2008-05-07 08:45 PDT (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2008-05-07 03:56:51 PDT
When LayoutTests/fast/frames/viewsource-empty-attribute-value.html is run stand-alone, it fails due to a different frame name.

0. ./WebKitTools/Scripts/build-webkit
1. ./WebKitTools/Scripts/run-webkit-tests fast/frames/viewsource-empty-attribute-value.html

Tests fails.

Unknown.  Only tested with WebKit r32774.

I thought a similar issue had already been fixed in DumpRenderTree (where the frame number wasn't getting reset between tests).  I can't seem to find it, though.
Comment 1 David Kilzer (:ddkilzer) 2008-05-07 03:57:42 PDT
The failure looks like this:

--- /tmp/layout-test-results/fast/frames/viewsource-empty-attribute-value-expected.txt	2008-05-07 03:51:40.000000000 -0700
+++ /tmp/layout-test-results/fast/frames/viewsource-empty-attribute-value-actual.txt	2008-05-07 03:51:40.000000000 -0700
@@ -5,7 +5,7 @@
-Frame: '<!--framePath /1/<!--frame0-->-->'
+Frame: '<!--framePath //<!--frame0-->-->'
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> 
 <hr noshade width=75%> 
Comment 2 mitz@webkit.org 2008-05-07 08:45:02 PDT
Unique frame IDs are assigned in sequence through the lifetime of a WebView, so starting with a fresh WebView you get different identifiers.