Bug 189203 – Compile error in RealtimeOutgoingVideoSource.cpp; unused parameter in libwebrtc header

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Compile error in RealtimeOutgoingVideoSource.cpp; unused parameter in libwebrtc header

[Jer Noble]

Created attachment 348665 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348665 [details]
Patch

Clearing flags on attachment: 348665

Committed r235575: <https://trac.webkit.org/changeset/235575>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43960652>

[Darin Adler]

Would be nice to eventually change this in libwebrtc itself unless there is some reason the header has to have an unused parameter in it. Even if the libwebrtc project itself doesn’t want to compile with this warning, it’s nice for headers at least to be compatible with it.

[youenn fablet]

(In reply to Darin Adler from comment #5)
> Would be nice to eventually change this in libwebrtc itself unless there is
> some reason the header has to have an unused parameter in it. Even if the
> libwebrtc project itself doesn’t want to compile with this warning, it’s
> nice for headers at least to be compatible with it.

We started discussing with the project upstream but there is no concrete plan yet there.
I am not sure how tractable it would be for the upstream project to make the headers compatible without actually enforcing this at compile time.

We were previously patching these files but this proved to be a hurdle for every libwebrtc refresh.
We should probably try to reduce WebCore dependency on libwebrtc headers.