RESOLVED CONFIGURATION CHANGED 189201
IDBRequest and IDBCursor should not hold strong references to JSValue 
https://bugs.webkit.org/show_bug.cgi?id=189201
Summary IDBRequest and IDBCursor should not hold strong references to JSValue
youenn fablet
Reported 2018-08-31 11:07:53 PDT
As can be seen from some IDB tests, this creates memory leaks. Instead use JSValueInWrappedObject.
Attachments
Patch (23.36 KB, patch)
2018-08-31 11:18 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (23.37 KB, patch)
2018-08-31 13:42 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.98 MB, application/zip)
2018-08-31 17:08 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.41 MB, application/zip)
2018-08-31 17:49 PDT, EWS Watchlist 		no flags
Details
Patch (26.07 KB, patch)
2018-08-31 22:51 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (26.14 KB, patch)
2018-09-01 08:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.35 MB, application/zip)
2018-09-01 09:09 PDT, EWS Watchlist 		no flags
Details
Patch (28.37 KB, patch)
2018-09-04 10:52 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-08-31 11:18:13 PDT
Created attachment 348654 [details] Patch
youenn fablet
Comment 2 2018-08-31 13:42:35 PDT
Created attachment 348669 [details] Patch
Alex Christensen
Comment 3 2018-08-31 13:44:02 PDT
Comment on attachment 348669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348669&action=review > Source/WebCore/Modules/indexeddb/IDBCursor.h:104 > // FIXME: The following uses of JSC::Strong are incorrect and can lead to storage leaks > // due to reference cycles; we should use JSValueInWrappedObject instead. This comment should be removed.
EWS Watchlist
Comment 4 2018-08-31 17:08:06 PDT
Comment on attachment 348669 [details] Patch Attachment 348669 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9055070 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html
EWS Watchlist
Comment 5 2018-08-31 17:08:08 PDT
Created attachment 348684 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-08-31 17:49:52 PDT
Comment on attachment 348669 [details] Patch Attachment 348669 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9055166 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html
EWS Watchlist
Comment 7 2018-08-31 17:49:54 PDT
Created attachment 348692 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
youenn fablet
Comment 8 2018-08-31 22:51:44 PDT
Created attachment 348707 [details] Patch
youenn fablet
Comment 9 2018-09-01 08:03:05 PDT
Created attachment 348712 [details] Patch
EWS Watchlist
Comment 10 2018-09-01 09:09:05 PDT
Comment on attachment 348712 [details] Patch Attachment 348712 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9062021 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html
EWS Watchlist
Comment 11 2018-09-01 09:09:07 PDT
Created attachment 348714 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
youenn fablet
Comment 12 2018-09-04 10:52:42 PDT
Created attachment 348826 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.