Bug 189197 - [JSC] [Armv7] implement patchableBranch8()
Summary: [JSC] [Armv7] implement patchableBranch8()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-31 10:00 PDT by Guillaume Emont
Modified: 2018-08-31 10:29 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2018-08-31 10:17 PDT, Guillaume Emont
guijemont: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2018-08-31 10:00:01 PDT
The build is broken for Armv7 since r235517 because it needs an implementation of that method.
Comment 1 Guillaume Emont 2018-08-31 10:17:45 PDT
Created attachment 348646 [details]
Patch

Tentative implemention, currently running tests on a device to check that it does not break anything.
Comment 2 Guillaume Emont 2018-08-31 10:18:17 PDT
(In reply to Guillaume Emont from comment #1)
> Created attachment 348646 [details]
> Patch
> 
> Tentative implemention, currently running tests on a device to check that it
> does not break anything.

(Copy-pasted from the Arm64 implementation, but that should do).
Comment 3 Mark Lam 2018-08-31 10:26:20 PDT
I already landed a build fix for this in r235557: <https://trac.webkit.org/r235557>.  Does that not work?
Comment 4 Guillaume Emont 2018-08-31 10:28:13 PDT
(In reply to Mark Lam from comment #3)
> I already landed a build fix for this in r235557:
> <https://trac.webkit.org/r235557>.  Does that not work?

Yes, that should work, I had not seen it yet. Sorry for the noise.
Comment 5 Radar WebKit Bug Importer 2018-08-31 10:29:17 PDT
<rdar://problem/43945560>