Bug 189196 - [EME] Add layout test for InitData and InitDataType in WebM encrypted event
Summary: [EME] Add layout test for InitData and InitDataType in WebM encrypted event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 189200
  Show dependency tree / graph
 
Reported: 2018-08-31 09:57 PDT by Yacine Bandou
Modified: 2018-09-04 03:29 PDT (History)
7 users (show)

See Also:

Attachments
Patch (117.13 KB, patch)
2018-08-31 10:29 PDT, Yacine Bandou 		no flags Details | Formatted Diff | Diff
Patch (117.07 KB, patch)
2018-09-03 07:43 PDT, Yacine Bandou 		no flags Details | Formatted Diff | Diff
Patch (117.07 KB, patch)
2018-09-04 01:59 PDT, Yacine Bandou 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yacine Bandou 2018-08-31 09:57:56 PDT 
Add a new layout test in order to test the reception of the encrypted WebM event with an expected initData and initDataType fields.
Comment 1 Yacine Bandou 2018-08-31 10:29:38 PDT 
Created attachment 348648 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-09-03 04:07:25 PDT 
Comment on attachment 348648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348648&action=review

> LayoutTests/media/encrypted-media/medias-enc.js:30
> +                                                           ],

This ], can go to the line above.
Comment 3 Yacine Bandou 2018-09-03 07:43:41 PDT 
Created attachment 348771 [details]
Patch
Comment 4 Xabier Rodríguez Calvar 2018-09-04 01:26:39 PDT 
Comment on attachment 348771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348771&action=review

> LayoutTests/platform/wpe/TestExpectations:335
> +# Encrypted WebM is not supported yet

Sorry that I missed that in the previous review, but this comment needs a period at the end.
Comment 5 Yacine Bandou 2018-09-04 01:59:28 PDT 
Created attachment 348807 [details]
Patch
Comment 6 WebKit Commit Bot 2018-09-04 03:27:27 PDT 
Comment on attachment 348807 [details]
Patch

Clearing flags on attachment: 348807

Committed r235609: <https://trac.webkit.org/changeset/235609>
Comment 7 WebKit Commit Bot 2018-09-04 03:27:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-09-04 03:29:01 PDT 
<rdar://problem/44092393>