Bug 189193 - [LFC] Add margin box verification back now that Display::Box has non-computed horizontal margin.
Summary: [LFC] Add margin box verification back now that Display::Box has non-computed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-31 07:59 PDT by zalan
Modified: 2018-08-31 11:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.70 KB, patch)
2018-08-31 09:13 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-31 07:59:21 PDT 
ssia
Comment 1 zalan 2018-08-31 09:13:19 PDT 
Created attachment 348641 [details]
Patch
Comment 2 Antti Koivisto 2018-08-31 10:39:32 PDT 
Comment on attachment 348641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348641&action=review

> Source/WebCore/layout/Verification.cpp:132
> +            borderBox.top() - displayBox.nonCollapsedMarginTop()
> +            , borderBox.left() - displayBox.nonComputedMarginLeft()
> +            , displayBox.nonComputedMarginLeft() + borderBox.width() + displayBox.nonComputedMarginRight()
> +            , displayBox.nonCollapsedMarginTop() + borderBox.height() + displayBox.nonCollapsedMarginBottom() 

Those commas would look better at the end of the line.
Comment 3 zalan 2018-08-31 11:07:52 PDT 
Committed r235561: <https://trac.webkit.org/changeset/235561>
Comment 4 Radar WebKit Bug Importer 2018-08-31 11:08:19 PDT 
<rdar://problem/43947398>