Bug 189185 – Fix exception check accounting in constructJSWebAssemblyCompileError().

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

<rdar://problem/39786007>

[Mark Lam]

Created attachment 348616 [details]
proposed patch.

[Michael Saboff]

Comment on attachment 348616 [details]
proposed patch.

r=me

[WebKit Commit Bot]

Comment on attachment 348616 [details]
proposed patch.

Clearing flags on attachment: 348616

Committed r235558: <https://trac.webkit.org/changeset/235558>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Saam Barati]

Comment on attachment 348616 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=348616&action=review

> Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51
> +        auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error());

Why would creating the exception throw an exception?

[Mark Lam]

(In reply to Saam Barati from comment #5)
> Comment on attachment 348616 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348616&action=review
> 
> > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51
> > +        auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error());
> 
> Why would creating the exception throw an exception?

See "static JSWebAssemblyCompileError* create(ExecState* exec, VM& vm, Structure* structure, JSValue message)" in JSWebAssemblyCompileError.h.  It calls message.toWTFString(exec) which can throw.

[Saam Barati]

(In reply to Mark Lam from comment #6)
> (In reply to Saam Barati from comment #5)
> > Comment on attachment 348616 [details]
> > proposed patch.
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=348616&action=review
> > 
> > > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51
> > > +        auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error());
> > 
> > Why would creating the exception throw an exception?
> 
> See "static JSWebAssemblyCompileError* create(ExecState* exec, VM& vm,
> Structure* structure, JSValue message)" in JSWebAssemblyCompileError.h.  It
> calls message.toWTFString(exec) which can throw.

Ok, makes sense.

[Dawei Fenton (:realdawei)]

Reopening to attach new patch.

[Dawei Fenton (:realdawei)]

Created attachment 348827 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348827 [details]
Patch

Clearing flags on attachment: 348827

Committed r235624: <https://trac.webkit.org/changeset/235624>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.