Bug 189183 – slotchange-event-bubbling.html fails in Chrome & Firefox

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

There is a bug in slotchange-event-bubbling.html such that it fails in Chrome & Firefox.
We would start failing this test as well once the bug 189144 is fixed.

[Ryosuke Niwa]

Created attachment 348600 [details]
Fixes the test

[Chris Dumez]

Comment on attachment 348600 [details]
Fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=348600&action=review

> LayoutTests/ChangeLog:8
> +        slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes.

Typo: assinged

> LayoutTests/ChangeLog:10
> +        Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask

Typo: implements -> implement / fails -> fail

> LayoutTests/ChangeLog:13
> +        Fixed the test by manually waiting for the current microtask queue is emptied after constructing

is emptied -> to be emptied?

[Ryosuke Niwa]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 348600 [details]
> Fixes the test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348600&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes.
> 
> Typo: assinged

Fixed.

> > LayoutTests/ChangeLog:10
> > +        Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask
> 
> Typo: implements -> implement / fails -> fail

Fixed.

> > LayoutTests/ChangeLog:13
> > +        Fixed the test by manually waiting for the current microtask queue is emptied after constructing
> 
> is emptied -> to be emptied?

Fixed.

[Ryosuke Niwa]

Committed r235568: <https://trac.webkit.org/changeset/235568>

[Radar WebKit Bug Importer]

<rdar://problem/43953435>