Bug 189180 - Move stats gathering out of LibWebRTCMediaEndpoint
Summary: Move stats gathering out of LibWebRTCMediaEndpoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 21:17 PDT by youenn fablet
Modified: 2018-08-31 16:28 PDT (History)
7 users (show)

See Also:

Attachments
Patch (46.70 KB, patch)
2018-08-30 21:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (46.72 KB, patch)
2018-08-30 21:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (47.55 KB, patch)
2018-08-31 13:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-08-30 21:17:35 PDT 
refactoring to ease future developments
Comment 1 youenn fablet 2018-08-30 21:40:33 PDT 
Created attachment 348598 [details]
Patch
Comment 2 EWS Watchlist 2018-08-30 21:42:31 PDT 
Attachment 348598 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 youenn fablet 2018-08-30 21:47:22 PDT 
Created attachment 348602 [details]
Patch
Comment 4 EWS Watchlist 2018-08-30 21:49:40 PDT 
Attachment 348602 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alejandro G. Castro 2018-08-31 06:18:46 PDT 
Comment on attachment 348602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348602&action=review

LGTM

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

2018

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

2018
Comment 6 Jon Lee 2018-08-31 13:22:30 PDT 
Comment on attachment 348602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348602&action=review

> Source/WebCore/ChangeLog:13
> +        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

Please update the copyright years on these files.
Comment 7 youenn fablet 2018-08-31 13:46:53 PDT 
Created attachment 348670 [details]
Patch for landing
Comment 8 EWS Watchlist 2018-08-31 13:48:15 PDT 
Attachment 348670 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 youenn fablet 2018-08-31 13:48:29 PDT 
(In reply to youenn fablet from comment #7)
> Created attachment 348670 [details]
> Patch for landing

Thanks for the review, I updated copyrights accordingly.
Comment 10 WebKit Commit Bot 2018-08-31 16:27:29 PDT 
Comment on attachment 348670 [details]
Patch for landing

Clearing flags on attachment: 348670

Committed r235576: <https://trac.webkit.org/changeset/235576>
Comment 11 WebKit Commit Bot 2018-08-31 16:27:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-08-31 16:28:16 PDT 
<rdar://problem/43960905>