Bug 189179 - [GTK] GLContextGLX::createWindowContext should cope when no config is found
Summary: [GTK] GLContextGLX::createWindowContext should cope when no config is found
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-30 20:15 PDT by Daniel Drake
Modified: 2018-09-10 17:25 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Drake 2018-08-30 20:15:40 PDT
We are seeing a crash on Intel GeminiLake platforms where the web process crashes with:

(WebKitWebProcess:5058): Gdk-ERROR **: The program 'WebKitWebProcess' received an X Window System error.
This probably reflects a bug in the program.
The error was 'GLXBadFBConfig'.
  (Details: serial 202 error_code 178 request_code 155 (GLX) minor_code 34)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

Tracing through, this happens because WebKit is calling glXCreateContextAttribsARB() with a NULL GLXFBConfig. This causes glvnd to raise an X error.

Why was GLContextGLX::createWindowContext unable to find a usable FBConfig? I don't fully understand the situation; I've provided some detail on it here:
https://lists.freedesktop.org/archives/xorg-devel/2018-August/057477.html

Regardless of that, it seems like webkit should probably do something better than it currently does (crash) when no config is found, e.g. fall back on non-composited gfx codepath?
Comment 1 Daniel Drake 2018-09-06 21:46:40 PDT
Actually according to Jasper, webkit crashing is appropriate here, since the lack of appropriate FBConfig implies something wrong at the system level.
https://lists.freedesktop.org/archives/xorg-devel/2018-September/057535.html

Feel free to close as invalid if you agree!
Comment 2 Michael Catanzaro 2018-09-10 17:25:26 PDT
Oh, so Jasper is still around.

OK then!