Bug 189178 – Expose -apple-system-container-border color to internal web views

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[James Savage]

<rdar://problem/41749096>

[James Savage]

Created attachment 348575 [details]
Patch

[EWS Watchlist]

Comment on attachment 348575 [details]
Patch

Attachment 348575 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9043048

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 348578 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 348575 [details]
Patch

Attachment 348575 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9043261

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 348585 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 348575 [details]
Patch

Attachment 348575 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9044073

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 348587 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Radar WebKit Bug Importer]

<rdar://problem/43941916>

[Timothy Hatcher]

Comment on attachment 348575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348575&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:680
> +        case CSSValueAppleSystemContainerBorder:
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
> +            return systemAppearanceColor(cache.systemContainerBorderColor, @selector(containerBorderColor));
> +#else
> +            return 0xFFC5C5C5;
> +#endif

You only need to handle it here and use the special cache.systemContainerBorderColor if this color is different based on accent color. I don't think it is, so yo can simplify this patch by handling it with the other system colors further down in this file.

[James Savage]

Created attachment 349003 [details]
Patch

[EWS Watchlist]

Comment on attachment 349003 [details]
Patch

Attachment 349003 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9111372

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 349007 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[James Savage]

Okay I give up. Which expectation file do I need to edit for EWS to see the right results? The tests passed when I ran them locally.

[EWS Watchlist]

Comment on attachment 349003 [details]
Patch

Attachment 349003 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9111408

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 349008 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349003 [details]
Patch

Attachment 349003 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9116422

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 349054 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Comment on attachment 349003 [details]
Patch

You need to commit platform specific results to make the tests happy.

[James Savage]

(In reply to Timothy Hatcher from comment #18)
> Comment on attachment 349003 [details]
> Patch
> 
> You need to commit platform specific results to make the tests happy.

Do you know specifically which file. I’m assuming its LayoutTests/platform/mac/fast/css/apple-system-colors-expected.txt, but I was basing this off your change in <https://trac.webkit.org/changeset/232847/webkit/> which only touched LayoutTests/fast/css/apple-system-control-colors-expected.txt.

[James Savage]

Created attachment 349222 [details]
Patch for EWS

[EWS Watchlist]

Comment on attachment 349222 [details]
Patch for EWS

Attachment 349222 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9135725

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 349228 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[James Savage]

Created attachment 349232 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 349232 [details]
Patch

Clearing flags on attachment: 349232

Committed r235866: <https://trac.webkit.org/changeset/235866>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Looks like https://trac.webkit.org/changeset/235866/webkit

Has caused fast/css/apple-system-control-colors.html to fail on High Sierra currently. 


Test History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss%2Fapple-system-control-colors.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/fast/css/apple-system-control-colors-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/fast/css/apple-system-control-colors-actual.txt
@@ -19,5 +19,5 @@
 -apple-system-quaternary-label : rgba(0, 0, 0, 0.0980392)
 -apple-system-grid : rgb(204, 204, 204)
 -apple-system-separator : rgb(204, 204, 204)
--apple-system-container-border : rgb(197, 197, 197)
+-apple-system-container-border : rgba(0, 0, 0, 0)
 current-color with inherited -apple-system-label : rgba(0, 0, 0, 0.85098)

[Truitt Savell]

Test rebaselined in https://trac.webkit.org/changeset/235874/webkit

[James Savage]

Created attachment 349366 [details]
Follow up changes for High Sierra

[Ryan Haddad]

Reopening for follow up patch.

[WebKit Commit Bot]

Comment on attachment 349366 [details]
Follow up changes for High Sierra

Rejecting attachment 349366 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 349366, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/9174138

[Timothy Hatcher]

Comment on attachment 349366 [details]
Follow up changes for High Sierra

View in context: https://bugs.webkit.org/attachment.cgi?id=349366&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).

Needs removed to land.

[James Savage]

Created attachment 349470 [details]
Follow up changes for High Sierra

[EWS]

Comment on attachment 349470 [details]
Follow up changes for High Sierra

Rejecting attachment 349470 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 349470 [details]
Follow up changes for High Sierra

Clearing flags on attachment: 349470

Committed r235922: <https://trac.webkit.org/changeset/235922>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.