This is a first step towards using libwebrtc sender and receiver objects when unified plan is on.
Created attachment 348541 [details] WIP
Created attachment 348558 [details] Patch
Created attachment 348560 [details] Patch
Attachment 348560 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348565 [details] Patch
Attachment 348565 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348569 [details] Patch
Attachment 348569 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:1566: The item "Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp" should be added only once to the list. [list/duplicate] [5] ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348590 [details] Patch
Attachment 348590 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348603 [details] Patch
Attachment 348603 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 348603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348603&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:55 > + RTCRtpParameters getParameters(RTCRtpSender&) const final; Can probably move these two as private.
Comment on attachment 348603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348603&action=review LGTM, let's do it. > Source/WebCore/Modules/mediastream/RTCRtpReceiverBackend.h:2 > + * Copyright (C) 2015 Ericsson AB. All rights reserved. Probably you want to add Apple for this new file. > Source/WebCore/Modules/mediastream/RTCRtpReceiverBackend.h:16 > + * 3. Neither the name of Ericsson nor the names of its contributors > + * may be used to endorse or promote products derived from this > + * software without specific prior written permission. And remove this.
Created attachment 348821 [details] Patch for landing
Attachment 348821 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348823 [details] Patch for landing
Attachment 348823 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 348823 [details] Patch for landing Clearing flags on attachment: 348823 Committed r235623: <https://trac.webkit.org/changeset/235623>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44106285>