Bug 189170 - REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
Summary: REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 171100
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-30 13:34 PDT by Olivia Barnett
Modified: 2018-08-31 02:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2018-08-30 13:35 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Patch (1.36 KB, patch)
2018-08-30 13:42 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivia Barnett 2018-08-30 13:34:38 PDT 
REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
Comment 1 Olivia Barnett 2018-08-30 13:35:44 PDT 
Created attachment 348537 [details]
Patch
Comment 2 EWS Watchlist 2018-08-30 13:40:01 PDT 
Attachment 348537 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2018-08-30 13:40:44 PDT 
Comment on attachment 348537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348537&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Get this outta here. Maybe "No new tests; fixing a failing existing test."
Comment 4 Olivia Barnett 2018-08-30 13:42:59 PDT 
Created attachment 348540 [details]
Patch
Comment 5 WebKit Commit Bot 2018-08-30 14:33:45 PDT 
Comment on attachment 348540 [details]
Patch

Clearing flags on attachment: 348540

Committed r235524: <https://trac.webkit.org/changeset/235524>
Comment 6 WebKit Commit Bot 2018-08-30 14:33:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-31 02:54:03 PDT 
<rdar://problem/43932707>