Bug 189169 - Replace OptionSet |= and -= operators with add() and remove() functions
Summary: Replace OptionSet |= and -= operators with add() and remove() functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 13:22 PDT by Antti Koivisto
Modified: 2018-08-31 11:01 PDT (History)
5 users (show)

See Also:


Attachments
patch (99.41 KB, patch)
2018-08-30 14:19 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (102.74 KB, patch)
2018-08-31 00:50 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (103.66 KB, patch)
2018-08-31 01:15 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (104.48 KB, patch)
2018-08-31 02:06 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (108.89 KB, patch)
2018-08-31 02:53 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (114.17 KB, patch)
2018-08-31 03:03 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (118.55 KB, patch)
2018-08-31 04:00 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (123.86 KB, patch)
2018-08-31 04:47 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-08-30 13:22:04 PDT
It makes code more readable.
Comment 1 Antti Koivisto 2018-08-30 14:19:22 PDT
Created attachment 348548 [details]
patch
Comment 2 Build Bot 2018-08-30 14:22:48 PDT
Attachment 348548 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/UserActionElementSet.cpp:69:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2018-08-31 00:50:10 PDT
Created attachment 348618 [details]
patch
Comment 4 Build Bot 2018-08-31 00:53:10 PDT
Attachment 348618 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/OptionSet.cpp:111:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 68 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Antti Koivisto 2018-08-31 01:15:37 PDT
Created attachment 348620 [details]
patch
Comment 6 Antti Koivisto 2018-08-31 02:06:28 PDT
Created attachment 348622 [details]
patch
Comment 7 Antti Koivisto 2018-08-31 02:53:59 PDT
Created attachment 348626 [details]
patch
Comment 8 Antti Koivisto 2018-08-31 03:03:05 PDT
Created attachment 348628 [details]
patch
Comment 9 Antti Koivisto 2018-08-31 04:00:26 PDT
Created attachment 348630 [details]
patch
Comment 10 Antti Koivisto 2018-08-31 04:47:29 PDT
Created attachment 348633 [details]
patch
Comment 11 Anders Carlsson 2018-08-31 08:09:47 PDT
Comment on attachment 348633 [details]
patch

rs=me
Comment 12 Brent Fulgham 2018-08-31 08:15:18 PDT
Comment on attachment 348633 [details]
patch

I love this change!
Comment 13 WebKit Commit Bot 2018-08-31 10:59:12 PDT
Comment on attachment 348633 [details]
patch

Clearing flags on attachment: 348633

Committed r235560: <https://trac.webkit.org/changeset/235560>
Comment 14 WebKit Commit Bot 2018-08-31 10:59:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-08-31 11:01:26 PDT
<rdar://problem/43947059>