...
Created attachment 348513 [details] Patch
Comment on attachment 348513 [details] Patch Attachment 348513 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9037344 New failing tests: imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html fast/forms/color/input-appearance-color.html
Created attachment 348536 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 348513 [details] Patch Attachment 348513 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9039230 New failing tests: imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html fast/forms/color/input-appearance-color.html
Created attachment 348557 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 348566 [details] Patch
Attachment 348566 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:135: Should not have spaces around = in property synthesis. [whitespace/property] [4] Total errors found: 1 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348567 [details] Patch
Created attachment 348642 [details] Patch
Comment on attachment 348642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348642&action=review > Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:56 > + __weak id<WKPopoverColorWellDelegate> _webDelegate; I think we typically use WeakObjCPtr for this.
Comment on attachment 348642 [details] Patch We should also make this an experimental feature (by updating WebPreferences.yaml)
Created attachment 351810 [details] Rebase on trunk
Comment on attachment 351810 [details] Rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=351810&action=review > Source/WebKit/Shared/WebPreferences.yaml:1393 > + humanReadableName: "Input type color" This is not a good name for the menu > Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:158 > + return _webDelegate.get().get(); I think this should be getAutoreleased.
Comment on attachment 351810 [details] Rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=351810&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1393 >> + humanReadableName: "Input type color" > > This is not a good name for the menu => "Color Inputs" >> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:158 >> + return _webDelegate.get().get(); > > I think this should be getAutoreleased. 👍
Created attachment 351815 [details] Patch for landing
Comment on attachment 351815 [details] Patch for landing Clearing flags on attachment: 351815 Committed r236942: <https://trac.webkit.org/changeset/236942>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45107210>
Reopening to attach new patch.
Created attachment 351833 [details] Patch for landing
Looks like this revision: https://trac.webkit.org/changeset/236942/webkit May have caused an API failure. Example: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/13298 Output: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20%28Tests%29/builds/13298/steps/run-api-tests/logs/stdio Excerpt: Failed TestWebKitAPI.DragAndDropTests.DropColor /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:89 Expected equality of these values: @"#ff0000" Which is: "#ff0000" [webView stringByEvaluatingJavaScript:@"document.querySelector(\"input\").value"] Which is: "#ff2600" Failure seems to be flaky.
(In reply to Truitt Savell from comment #21) > Looks like this revision: https://trac.webkit.org/changeset/236942/webkit > > May have caused an API failure. > > Example: > https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/ > builds/13298 > > Output: > https://build.webkit.org/builders/ > Apple%20Sierra%20Release%20WK1%20%28Tests%29/builds/13298/steps/run-api- > tests/logs/stdio > > Excerpt: > Failed > > TestWebKitAPI.DragAndDropTests.DropColor > > > /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/mac/ > DragAndDropTestsMac.mm:89 > Expected equality of these values: > @"#ff0000" > Which is: "#ff0000" > [webView > stringByEvaluatingJavaScript:@"document.querySelector(\"input\").value"] > Which is: "#ff2600" > > Failure seems to be flaky. Ok! Taking a look now...
Comment on attachment 351833 [details] Patch for landing Clearing flags on attachment: 351833 Committed r236951: <https://trac.webkit.org/changeset/236951>
(In reply to Wenson Hsieh from comment #22) > (In reply to Truitt Savell from comment #21) > > Looks like this revision: https://trac.webkit.org/changeset/236942/webkit > > > > May have caused an API failure. > > > > Example: > > https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/ > > builds/13298 > > > > Output: > > https://build.webkit.org/builders/ > > Apple%20Sierra%20Release%20WK1%20%28Tests%29/builds/13298/steps/run-api- > > tests/logs/stdio > > > > Excerpt: > > Failed > > > > TestWebKitAPI.DragAndDropTests.DropColor > > > > > > /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/mac/ > > DragAndDropTestsMac.mm:89 > > Expected equality of these values: > > @"#ff0000" > > Which is: "#ff0000" > > [webView > > stringByEvaluatingJavaScript:@"document.querySelector(\"input\").value"] > > Which is: "#ff2600" > > > > Failure seems to be flaky. > > Ok! Taking a look now... Fixing this in <https://bugs.webkit.org/show_bug.cgi?id=190386>.