Bug 189160 – WebAudioBufferList.cpp/.h is named as cocoa/WebAudioBufferList.cpp/.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

Updating the XCode project file then modifies unnecessarily it for these files

[youenn fablet]

Created attachment 348516 [details]
Patch

[youenn fablet]

Created attachment 348533 [details]
Patch

[youenn fablet]

Created attachment 348559 [details]
Rebasing

[youenn fablet]

Created attachment 348604 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348604 [details]
Patch

Rejecting attachment 348604 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 348604, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348604&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=189160&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 348604 from bug 189160.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348604
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PlatformMac.cmake
patching file Source/WebCore/SourcesCocoa.txt
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 succeeded at 1086 (offset -2 lines).
Hunk #2 succeeded at 1096 (offset -2 lines).
Hunk #3 succeeded at 3959 (offset -2 lines).
Hunk #4 FAILED at 4059.
Hunk #5 succeeded at 7254 (offset -3 lines).
Hunk #6 succeeded at 13128 (offset -3 lines).
Hunk #7 succeeded at 13184 (offset -3 lines).
Hunk #8 FAILED at 13365.
Hunk #9 FAILED at 24562.
Hunk #10 succeeded at 27249 (offset -5 lines).
Hunk #11 FAILED at 27274.
Hunk #12 succeeded at 29346 (offset -6 lines).
Hunk #13 succeeded at 29995 (offset -6 lines).
Hunk #14 FAILED at 31363.
5 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9051182

[youenn fablet]

Created attachment 348656 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 348656 [details]
Patch for landing

Clearing flags on attachment: 348656

Committed r235563: <https://trac.webkit.org/changeset/235563>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43950658>