Bug 189157 - Web Share API compatible with AppleTV and WatchOS
Summary: Web Share API compatible with AppleTV and WatchOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 10:22 PDT by Olivia Barnett
Modified: 2018-08-31 02:58 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.71 KB, patch)
2018-08-30 10:23 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Patch (6.93 KB, patch)
2018-08-30 10:38 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2018-08-30 10:42 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Patch (6.74 KB, patch)
2018-08-30 10:44 PDT, Olivia Barnett 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivia Barnett 2018-08-30 10:22:57 PDT 
Web Share API compatible with AppleTV and WatchOS
Comment 1 Olivia Barnett 2018-08-30 10:23:50 PDT 
Created attachment 348503 [details]
Patch
Comment 2 Tim Horton 2018-08-30 10:26:20 PDT 
Comment on attachment 348503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348503&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.h:81
> +#define DEFAULT_WEB_SHARE_ENABLED true

Now it’s not defined to anything on those platforms. Put this in its own section down near the bottom, with just two cases (iOS and not watch and not tv -> true, otherwise false).
Comment 3 Olivia Barnett 2018-08-30 10:38:33 PDT 
Created attachment 348505 [details]
Patch
Comment 4 Tim Horton 2018-08-30 10:42:00 PDT 
Comment on attachment 348505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348505&action=review

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:26
> +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

This went too far north! Config.h and the file’s own header always come first
Comment 5 Olivia Barnett 2018-08-30 10:42:11 PDT 
Created attachment 348506 [details]
Patch
Comment 6 Olivia Barnett 2018-08-30 10:44:26 PDT 
Created attachment 348507 [details]
Patch
Comment 7 Tim Horton 2018-08-30 11:12:00 PDT 
Comment on attachment 348507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348507&action=review

> Source/WebKit/ChangeLog:3
> +        Web Share API compatible with AppleTV and WatchOS

For next time (but not this time since it's already in the CQ) the title ideally should either describe the /problem/ or say "Fix the build..."
Comment 8 WebKit Commit Bot 2018-08-30 11:30:06 PDT 
Comment on attachment 348507 [details]
Patch

Clearing flags on attachment: 348507

Committed r235512: <https://trac.webkit.org/changeset/235512>
Comment 9 WebKit Commit Bot 2018-08-30 11:30:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 David Kilzer (:ddkilzer) 2018-08-31 02:44:16 PDT 
(In reply to WebKit Commit Bot from comment #8)
> Comment on attachment 348507 [details]
> Patch
> 
> Clearing flags on attachment: 348507
> 
> Committed r235512: <https://trac.webkit.org/changeset/235512>

Follow-up build fix:

Committed r235520: <https://trac.webkit.org/changeset/235520>
Comment 11 Radar WebKit Bug Importer 2018-08-31 02:44:33 PDT 
<rdar://problem/43932330>
Comment 12 David Kilzer (:ddkilzer) 2018-08-31 02:55:43 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #10)
> (In reply to WebKit Commit Bot from comment #8)
> > Comment on attachment 348507 [details]
> > Patch
> > 
> > Clearing flags on attachment: 348507
> > 
> > Committed r235512: <https://trac.webkit.org/changeset/235512>
> 
> Follow-up build fix:
> 
> Committed r235520: <https://trac.webkit.org/changeset/235520>

And I think:

Committed r235530: <https://trac.webkit.org/changeset/235530>
Comment 13 David Kilzer (:ddkilzer) 2018-08-31 02:58:35 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #12)
> (In reply to David Kilzer (:ddkilzer) from comment #10)
> > (In reply to WebKit Commit Bot from comment #8)
> > > Comment on attachment 348507 [details]
> > > Patch
> > > 
> > > Clearing flags on attachment: 348507
> > > 
> > > Committed r235512: <https://trac.webkit.org/changeset/235512>
> > 
> > Follow-up build fix:
> > 
> > Committed r235520: <https://trac.webkit.org/changeset/235520>
> 
> And I think:
> 
> Committed r235530: <https://trac.webkit.org/changeset/235530>

And finally(?):

Committed r235534: <https://trac.webkit.org/changeset/235534>