Bug 189157 – Web Share API compatible with AppleTV and WatchOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Olivia Barnett]

Web Share API compatible with AppleTV and WatchOS

[Olivia Barnett]

Created attachment 348503 [details]
Patch

[Tim Horton]

Comment on attachment 348503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348503&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.h:81
> +#define DEFAULT_WEB_SHARE_ENABLED true

Now it’s not defined to anything on those platforms. Put this in its own section down near the bottom, with just two cases (iOS and not watch and not tv -> true, otherwise false).

[Olivia Barnett]

Created attachment 348505 [details]
Patch

[Tim Horton]

Comment on attachment 348505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348505&action=review

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:26
> +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

This went too far north! Config.h and the file’s own header always come first

[Olivia Barnett]

Created attachment 348506 [details]
Patch

[Olivia Barnett]

Created attachment 348507 [details]
Patch

[Tim Horton]

Comment on attachment 348507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348507&action=review

> Source/WebKit/ChangeLog:3
> +        Web Share API compatible with AppleTV and WatchOS

For next time (but not this time since it's already in the CQ) the title ideally should either describe the /problem/ or say "Fix the build..."

[WebKit Commit Bot]

Comment on attachment 348507 [details]
Patch

Clearing flags on attachment: 348507

Committed r235512: <https://trac.webkit.org/changeset/235512>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

(In reply to WebKit Commit Bot from comment #8)
> Comment on attachment 348507 [details]
> Patch
> 
> Clearing flags on attachment: 348507
> 
> Committed r235512: <https://trac.webkit.org/changeset/235512>

Follow-up build fix:

Committed r235520: <https://trac.webkit.org/changeset/235520>

[Radar WebKit Bug Importer]

<rdar://problem/43932330>

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #10)
> (In reply to WebKit Commit Bot from comment #8)
> > Comment on attachment 348507 [details]
> > Patch
> > 
> > Clearing flags on attachment: 348507
> > 
> > Committed r235512: <https://trac.webkit.org/changeset/235512>
> 
> Follow-up build fix:
> 
> Committed r235520: <https://trac.webkit.org/changeset/235520>

And I think:

Committed r235530: <https://trac.webkit.org/changeset/235530>

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #12)
> (In reply to David Kilzer (:ddkilzer) from comment #10)
> > (In reply to WebKit Commit Bot from comment #8)
> > > Comment on attachment 348507 [details]
> > > Patch
> > > 
> > > Clearing flags on attachment: 348507
> > > 
> > > Committed r235512: <https://trac.webkit.org/changeset/235512>
> > 
> > Follow-up build fix:
> > 
> > Committed r235520: <https://trac.webkit.org/changeset/235520>
> 
> And I think:
> 
> Committed r235530: <https://trac.webkit.org/changeset/235530>

And finally(?):

Committed r235534: <https://trac.webkit.org/changeset/235534>