Bug 189150 - [LFC][Floating] Block formatting context roots avoid floats.
Summary: [LFC][Floating] Block formatting context roots avoid floats.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-30 01:35 PDT by zalan
Modified: 2018-08-30 07:46 PDT (History)
6 users (show)

See Also:


Attachments
Patch (20.84 KB, patch)
2018-08-30 01:48 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (20.85 KB, patch)
2018-08-30 01:51 PDT, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-30 01:35:11 PDT
so that floats don't intrude anymore.
Comment 1 zalan 2018-08-30 01:48:27 PDT
Created attachment 348491 [details]
Patch
Comment 2 zalan 2018-08-30 01:51:16 PDT
Created attachment 348492 [details]
Patch
Comment 3 EWS Watchlist 2018-08-30 01:53:37 PDT
Attachment 348492 [details] did not pass style-queue:


ERROR: Source/WebCore/layout/floats/FloatingContext.h:54:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 zalan 2018-08-30 07:45:06 PDT
Committed r235505: <https://trac.webkit.org/changeset/235505>
Comment 5 Radar WebKit Bug Importer 2018-08-30 07:46:15 PDT
<rdar://problem/43885285>