Bug 189146 – Add assignedElements to HTMLSlotElement

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Add a variant of assignedNodes which returns elements.
Added in https://github.com/whatwg/html/pull/2269.

[Ryosuke Niwa]

Created attachment 348485 [details]
Adds the method

[Radar WebKit Bug Importer]

<rdar://problem/43872965>

[Darin Adler]

Comment on attachment 348485 [details]
Adds the method

View in context: https://bugs.webkit.org/attachment.cgi?id=348485&action=review

> Source/WebCore/html/HTMLSlotElement.h:43
>      Vector<Node*> assignedNodes(const AssignedNodesOptions&) const;
> +    Vector<Ref<Element>> assignedElements(const AssignedNodesOptions&) const;

Why does assignedNodes return Node* instead of Ref<Node>? Why not make the two consistent?

[Ryosuke Niwa]

(In reply to Darin Adler from comment #3)
> Comment on attachment 348485 [details]
> Adds the method
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348485&action=review
> 
> > Source/WebCore/html/HTMLSlotElement.h:43
> >      Vector<Node*> assignedNodes(const AssignedNodesOptions&) const;
> > +    Vector<Ref<Element>> assignedElements(const AssignedNodesOptions&) const;
> 
> Why does assignedNodes return Node* instead of Ref<Node>? Why not make the
> two consistent?

That's a good point. Since we're making a copy in both cases, we should probably always return Vector<Ref<~>>. Will fix before landing.

[Ryosuke Niwa]

Committed r235535: <https://trac.webkit.org/changeset/235535>

[Anne van Kesteren]

*** Bug 180908 has been marked as a duplicate of this bug. ***