Bug 189141 - [LFC][Margins] Add non-computed horizontal margins to DisplayBox
Summary: [LFC][Margins] Add non-computed horizontal margins to DisplayBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-29 19:54 PDT by zalan
Modified: 2018-08-30 07:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.70 KB, patch)
2018-08-29 20:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (17.90 KB, patch)
2018-08-29 21:15 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-29 19:54:21 PDT 
in-flow block boxes' horizontal margin extends to the containing block's content box. In some cases (float avoiding) we need the non-extended, original values.
Comment 1 zalan 2018-08-29 20:00:34 PDT 
Created attachment 348473 [details]
Patch
Comment 2 zalan 2018-08-29 21:15:35 PDT 
Created attachment 348482 [details]
Patch
Comment 3 Antti Koivisto 2018-08-30 06:42:54 PDT 
Comment on attachment 348482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348482&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:241
> +        return WidthAndMargin { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } };

return { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } } ;

should work too?
Comment 4 Antti Koivisto 2018-08-30 06:45:35 PDT 
Comment on attachment 348482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348482&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:420
> +    return { *left, *right, { *width, { *marginLeft, *marginRight }, {nonComputedMarginLeft, nonComputedMarginRight } } };

Missing space before nonComputedMarginLeft
Comment 5 zalan 2018-08-30 07:25:59 PDT 
Committed r235501: <https://trac.webkit.org/changeset/235501>
Comment 6 Radar WebKit Bug Importer 2018-08-30 07:26:14 PDT 
<rdar://problem/43884877>