WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189141
[LFC][Margins] Add non-computed horizontal margins to DisplayBox
https://bugs.webkit.org/show_bug.cgi?id=189141
Summary
[LFC][Margins] Add non-computed horizontal margins to DisplayBox
alan
Reported
2018-08-29 19:54:21 PDT
in-flow block boxes' horizontal margin extends to the containing block's content box. In some cases (float avoiding) we need the non-extended, original values.
Attachments
Patch
(16.70 KB, patch)
2018-08-29 20:00 PDT
,
alan
no flags
Details
Formatted Diff
Diff
Patch
(17.90 KB, patch)
2018-08-29 21:15 PDT
,
alan
koivisto
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
alan
Comment 1
2018-08-29 20:00:34 PDT
Created
attachment 348473
[details]
Patch
alan
Comment 2
2018-08-29 21:15:35 PDT
Created
attachment 348482
[details]
Patch
Antti Koivisto
Comment 3
2018-08-30 06:42:54 PDT
Comment on
attachment 348482
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=348482&action=review
> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:241 > + return WidthAndMargin { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } };
return { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } } ; should work too?
Antti Koivisto
Comment 4
2018-08-30 06:45:35 PDT
Comment on
attachment 348482
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=348482&action=review
> Source/WebCore/layout/FormattingContextGeometry.cpp:420 > + return { *left, *right, { *width, { *marginLeft, *marginRight }, {nonComputedMarginLeft, nonComputedMarginRight } } };
Missing space before nonComputedMarginLeft
alan
Comment 5
2018-08-30 07:25:59 PDT
Committed
r235501
: <
https://trac.webkit.org/changeset/235501
>
Radar WebKit Bug Importer
Comment 6
2018-08-30 07:26:14 PDT
<
rdar://problem/43884877
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug