WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189139
Web Inspector: Dark Mode - Sidebar Class Toggle Button Wrong Color
https://bugs.webkit.org/show_bug.cgi?id=189139
Summary
Web Inspector: Dark Mode - Sidebar Class Toggle Button Wrong Color
Jamal Nasser
Reported
2018-08-29 19:14:20 PDT
Created
attachment 348465
[details]
Screenshot of wrong text color Class button on sidebar isn't the right color when using dark mode in web inspector.
Attachments
Screenshot of wrong text color
(391.91 KB, image/png)
2018-08-29 19:14 PDT
,
Jamal Nasser
no flags
Details
Proposed patch @ lines 1163-1165
(40.11 KB, text/plain)
2018-08-29 19:17 PDT
,
Jamal Nasser
no flags
Details
Screenshot of correct text color
(396.80 KB, image/png)
2018-08-29 19:18 PDT
,
Jamal Nasser
no flags
Details
Patch
(615 bytes, patch)
2018-08-31 07:50 PDT
,
Jamal Nasser
no flags
Details
Formatted Diff
Diff
Patch
(1.33 KB, patch)
2018-08-31 15:31 PDT
,
Jamal Nasser
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Jamal Nasser
Comment 1
2018-08-29 19:17:02 PDT
Created
attachment 348466
[details]
Proposed patch @ lines 1163-1165 Uses correct variable for color
Jamal Nasser
Comment 2
2018-08-29 19:18:51 PDT
Created
attachment 348468
[details]
Screenshot of correct text color
Jamal Nasser
Comment 3
2018-08-31 07:50:02 PDT
Created
attachment 348639
[details]
Patch
Matt Baker
Comment 4
2018-08-31 10:36:16 PDT
Comment on
attachment 348639
[details]
Patch rs=me
WebKit Commit Bot
Comment 5
2018-08-31 11:03:44 PDT
Comment on
attachment 348639
[details]
Patch Rejecting
attachment 348639
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 348639, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as
commit-queue@webkit.org
... Fetching:
https://bugs.webkit.org/attachment.cgi?id=348639&action=edit
Fetching:
https://bugs.webkit.org/show_bug.cgi?id=189139
&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 348639 from
bug 189139
. Fetching:
https://bugs.webkit.org/attachment.cgi?id=348639
Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See:
http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See:
http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See:
http://webkit.org/coding/contributing.html
Updating OpenSource From
https://git.webkit.org/git/WebKit
65619d48525..9223bcce80b master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 235558 = 65619d485251a3ffd87b48ab29b342956f3dcdc7
r235559
= 1716794964edcbc43fbefdc4c20a77cbb66fb682
r235560
= 9223bcce80b93e8f41d8ad6651a023b14a7181b9 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output:
https://webkit-queues.webkit.org/results/9052320
Jamal Nasser
Comment 6
2018-08-31 15:31:31 PDT
Created
attachment 348678
[details]
Patch
WebKit Commit Bot
Comment 7
2018-08-31 16:28:34 PDT
Comment on
attachment 348678
[details]
Patch Clearing flags on attachment: 348678 Committed
r235577
: <
https://trac.webkit.org/changeset/235577
>
WebKit Commit Bot
Comment 8
2018-08-31 16:28:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9
2018-08-31 16:29:17 PDT
<
rdar://problem/43960939
>
Joseph Pecoraro
Comment 10
2018-09-10 14:12:20 PDT
Nice! Thanks for the fix! =)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug