Avoid code duplication in ResourceLoadStatisticsMemoryStore::processStatisticsAndDataRecords().
Created attachment 348449 [details] Patch
Comment on attachment 348449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348449&action=review > Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp:358 > + return; I guess there is a small behavior change if m_parameters.shouldNotifyPagesWhenDataRecordsWereScanned value is updated between the time removeDataRecords is called and the lambda is executed.
Comment on attachment 348449 [details] Patch Clearing flags on attachment: 348449 Committed r235495: <https://trac.webkit.org/changeset/235495>
All reviewed patches have been landed. Closing bug.
<rdar://problem/43871000>
Comment on attachment 348449 [details] Patch If I recall correctly, this didn't use to be a pure duplication. There was something about the order in which things were done. But now it is totally a duplication and the patch looks good to me. (The code has been moved and changed too much for me to easily find out what the difference used to be.)
(In reply to John Wilander from comment #6) > Comment on attachment 348449 [details] > Patch > > If I recall correctly, this didn't use to be a pure duplication. There was > something about the order in which things were done. But now it is totally a > duplication and the patch looks good to me. > > (The code has been moved and changed too much for me to easily find out what > the difference used to be.) Ok, that makes sense. This code has been refactored a lot. Thanks for checking.