Enable USE_MEDIASOURCE on iOS
Created attachment 348430 [details] Patch
Comment on attachment 348430 [details] Patch Attachment 348430 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9027334 New failing tests: media/video-main-content-deny-obscured.html media/remove-video-best-media-element-in-main-frame-crash.html
Created attachment 348444 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 348450 [details] Patch
Comment on attachment 348450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348450&action=review > Source/WTF/ChangeLog:3 > + Enable USE_MEDIASOURCE on iOS Do you mean media remote?
(In reply to Jon Lee from comment #5) > Comment on attachment 348450 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348450&action=review > > > Source/WTF/ChangeLog:3 > > + Enable USE_MEDIASOURCE on iOS > > Do you mean media remote? Whoops, Freudian slip.
Created attachment 348530 [details] Patch
Created attachment 348553 [details] Patch
Created attachment 348644 [details] Patch
Created attachment 348645 [details] Patch
Created attachment 349316 [details] Patch
Created attachment 349408 [details] Patch
Created attachment 349442 [details] Patch
Created attachment 349446 [details] Patch
Comment on attachment 349446 [details] Patch ++NLOC!
Comment on attachment 349446 [details] Patch Clearing flags on attachment: 349446 Committed r235990: <https://trac.webkit.org/changeset/235990>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44434472>
The following API tests are timing out on iOS Simulator after this change: TestWebKitAPI.NowPlayingTest.VideoElementWithMutedAudio TestWebKitAPI.NowPlayingTest.VideoElementWithoutAudioPlayWithUserGesture TestWebKitAPI.NowPlayingTest.VideoElementWithoutAudio TestWebKitAPI.NowPlayingTest.AudioElement TestWebKitAPI.NowPlayingTest.VideoElementWithMutedAudioUnmutedWithUserGesture https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/7409
Reverted r235990 for reason: Introduced TestWebKitAPI.NowPlayingTest timeouts on iOS Committed r236011: <https://trac.webkit.org/changeset/236011>
Created attachment 349896 [details] Patch for landing
Created attachment 349897 [details] Patch for landing
Comment on attachment 349897 [details] Patch for landing Rejecting attachment 349897 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 349897, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9244349
Created attachment 349898 [details] Patch for landing
Comment on attachment 349898 [details] Patch for landing Rejecting attachment 349898 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 349898, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9244370
Created attachment 349904 [details] Patch for landing
Created attachment 349909 [details] Patch for landing
Comment on attachment 349909 [details] Patch for landing Clearing flags on attachment: 349909 Committed r236077: <https://trac.webkit.org/changeset/236077>