Bug 189093 – [CMake] Split Tools/CMakeLists.txt into platform files

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Don Olmstead]

Currently Tools/CMakeLists.txt is a big if else statement. Split this into Platform${PORT} files for ease of use especially for out of trunk ports.

[Don Olmstead]

Created attachment 348421 [details]
Patch

Splits the contents of CMakeLists.txt into Platform${PORT} files

[Don Olmstead]

Created attachment 348422 [details]
Patch

[Alex Christensen]

Looks good.  Please add a ChangeLog

[Don Olmstead]

(In reply to Alex Christensen from comment #3)
> Looks good.  Please add a ChangeLog

prepare-Changelog is just making one for Tools. Should it be modifying the root changelog?

[Alex Christensen]

Tools/ChangeLog

[Don Olmstead]

Comment on attachment 348422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348422&action=review

> Tools/ChangeLog:13
> [phone]  Don Olmstead  <[e-mail]>
> +
> +        [CMake] Split Tools/CMakeLists.txt into platform files
> +        https://bugs.webkit.org/show_bug.cgi?id=189093
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * CMakeLists.txt:
> +        * PlatformGTK.cmake: Added.
> +        * PlatformMac.cmake: Added.
> +        * PlatformWPE.cmake: Added.
> +        * PlatformWin.cmake: Added.
> +

Its over here

[Michael Catanzaro]

Comment on attachment 348422 [details]
Patch

Yeah, this is nicer.

And I see the ChangeLog is there!

[Alex Christensen]

Comment on attachment 348422 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348422&action=review

>> Tools/ChangeLog:13
>> +
> 
> Its over here

How did I miss this :(
Yep, it's fine.

[Don Olmstead]

(In reply to Alex Christensen from comment #8)
> Comment on attachment 348422 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348422&action=review
> 
> >> Tools/ChangeLog:13
> >> +
> > 
> > Its over here
> 
> How did I miss this :(
> Yep, it's fine.

We'll chalk it up to not enough ☕ this morning :)

Will land after EWS hears back from all the CMake ports.

[Don Olmstead]

Comment on attachment 348422 [details]
Patch

Tests are running and build on AppleWin so I think we're good

[WebKit Commit Bot]

Comment on attachment 348422 [details]
Patch

Clearing flags on attachment: 348422

Committed r235477: <https://trac.webkit.org/changeset/235477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.