Currently Tools/CMakeLists.txt is a big if else statement. Split this into Platform${PORT} files for ease of use especially for out of trunk ports.
Created attachment 348421 [details] Patch Splits the contents of CMakeLists.txt into Platform${PORT} files
Created attachment 348422 [details] Patch
Looks good. Please add a ChangeLog
(In reply to Alex Christensen from comment #3) > Looks good. Please add a ChangeLog prepare-Changelog is just making one for Tools. Should it be modifying the root changelog?
Tools/ChangeLog
Comment on attachment 348422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348422&action=review > Tools/ChangeLog:13 > +2018-08-29 Don Olmstead <don.olmstead@sony.com> > + > + [CMake] Split Tools/CMakeLists.txt into platform files > + https://bugs.webkit.org/show_bug.cgi?id=189093 > + > + Reviewed by NOBODY (OOPS!). > + > + * CMakeLists.txt: > + * PlatformGTK.cmake: Added. > + * PlatformMac.cmake: Added. > + * PlatformWPE.cmake: Added. > + * PlatformWin.cmake: Added. > + Its over here
Comment on attachment 348422 [details] Patch Yeah, this is nicer. And I see the ChangeLog is there!
Comment on attachment 348422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348422&action=review >> Tools/ChangeLog:13 >> + > > Its over here How did I miss this :( Yep, it's fine.
(In reply to Alex Christensen from comment #8) > Comment on attachment 348422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348422&action=review > > >> Tools/ChangeLog:13 > >> + > > > > Its over here > > How did I miss this :( > Yep, it's fine. We'll chalk it up to not enough ☕ this morning :) Will land after EWS hears back from all the CMake ports.
Comment on attachment 348422 [details] Patch Tests are running and build on AppleWin so I think we're good
Comment on attachment 348422 [details] Patch Clearing flags on attachment: 348422 Committed r235477: <https://trac.webkit.org/changeset/235477>
All reviewed patches have been landed. Closing bug.