Bug 189089 – Remove PseudoElementUserAgentCustom.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Emilio Cobos Álvarez (:emilio)]

Looks like it was added in bug 100826, but seems unused now, I couldn't find anything that set the pseudo attribute to something that wasn't -webkit- stuff, so this doesn't match anything.

I hope we can remove it without issues.

[Emilio Cobos Álvarez (:emilio)]

Test at https://github.com/web-platform-tests/wpt/pull/12743.

[Emilio Cobos Álvarez (:emilio)]

Created attachment 348416 [details]
Patch

[Darin Adler]

Ryosuke, would you review this patch?

[Myles C. Maxfield]

Looks good to me, but I'll let Ryosuke give the final review.

[Ryosuke Niwa]

Comment on attachment 348416 [details]
Patch

Sure, this looks unused now. ::part(~) would be a different implementation anyway.

[Ryosuke Niwa]

Note that this is a potentially Web incompatible change if some websites had been relying on these pseudo element names being valid in some of their rules. But the chance of it happening is low enough that I'm comfortable making this change given this isn't a feature ever exposed to the Web.

[Emilio Cobos Álvarez (:emilio)]

(In reply to Ryosuke Niwa from comment #6)
> Note that this is a potentially Web incompatible change if some websites had
> been relying on these pseudo element names being valid in some of their
> rules. But the chance of it happening is low enough that I'm comfortable
> making this change given this isn't a feature ever exposed to the Web.

Right, that's why I wanted to remove it if possible sooner rather than later.

Thanks a lot for the review!

[WebKit Commit Bot]

Comment on attachment 348416 [details]
Patch

Rejecting attachment 348416 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 348416, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348416&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=189089&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 348416 from bug 189089.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348416
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 5 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej
patching file Source/WebCore/css/CSSSelector.cpp
patching file Source/WebCore/css/CSSSelector.h
patching file Source/WebCore/css/RuleSet.cpp
patching file Source/WebCore/css/parser/CSSParserSelector.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9096418

[Emilio Cobos Álvarez (:emilio)]

Committed r235652: <https://trac.webkit.org/changeset/235652>

[Radar WebKit Bug Importer]

<rdar://problem/44121968>