Make it possible to mark tests as leaks in TestExpectations
Created attachment 348411 [details]
Needs the patch from bug 189067.
Is the intention to have this enabled by default or to have a queue explicitly testing it?
Enabled by default on some platforms.
Created attachment 348424 [details]
Comment on attachment 348424 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=348424&action=review
> +Bug(test) failures/expected/leaky-reftest.html [ ImageOnlyFailure Leak ]
I still think that "Leak" is a confusing name for this - I definitely wouldn't think that it has any relationship to document leaks.
I went with "leak" because "abandoned document" is too long, we may want to track other types of leaked objects (e.g. Frames) later, and it's consistent with the "world leak" term that WebKit has used historically.
Created attachment 348435 [details]
Comment on attachment 348435 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=348435&action=review
> - 'Leak': 'LEAK',
There are enough here that maybe the list should just be alphabetized...?
Not part of your patch, but it seems like this is wrong.
> self.assertEqual(TestExpectations.remove_pixel_failures(set([PASS, IMAGE, CRASH])), set([PASS, CRASH]))
Maybe add some test cases with LEAK here?