Bug 189088 – Make it possible to mark tests as leaks in TestExpectations

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Make it possible to mark tests as leaks in TestExpectations

[Simon Fraser (smfr)]

Created attachment 348411 [details]
Patch

[Simon Fraser (smfr)]

Needs the patch from bug 189067.

[Jonathan Bedard]

Is the intention to have this enabled by default or to have a queue explicitly testing it?

[Simon Fraser (smfr)]

Enabled by default on some platforms.

[Simon Fraser (smfr)]

Created attachment 348424 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 348424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348424&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:75
> +Bug(test) failures/expected/leaky-reftest.html [ ImageOnlyFailure Leak ]

I still think that "Leak" is a confusing name for this - I definitely wouldn't think that it has any relationship to document leaks.

[Simon Fraser (smfr)]

I went with "leak" because "abandoned document" is too long, we may want to track other types of leaked objects (e.g. Frames) later, and it's consistent with the "world leak" term that WebKit has used historically.

[Simon Fraser (smfr)]

Created attachment 348435 [details]
Patch

[Simon Fraser (smfr)]

Review ping?

[Jon Lee]

Comment on attachment 348435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348435&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:-248
> -        'Leak': 'LEAK',

There are enough here that maybe the list should just be alphabetized...?

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:868
>              expected_results.add(PASS)

Not part of your patch, but it seems like this is wrong.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:136
>          self.assertEqual(TestExpectations.remove_pixel_failures(set([PASS, IMAGE, CRASH])), set([PASS, CRASH]))

Maybe add some test cases with LEAK here?

[Simon Fraser (smfr)]

https://trac.webkit.org/r235564

[Radar WebKit Bug Importer]

<rdar://problem/43952197>