[CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
Created attachment 348380 [details] Patch
Created attachment 348383 [details] Patch
Created attachment 348387 [details] Patch
Created attachment 348471 [details] Patch
Created attachment 348716 [details] Patch
Comment on attachment 348716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348716&action=review I’d r+ but I don’t see an r?. > Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:177 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000) Not new to this patch, but in SPI headers we should be using the SDK version rather than the deployment target, since the goal of the header is to reflect the contents of an internal SDK header.
Comment on attachment 348716 [details] Patch Just noticed this is finally building, so setting review? on it now.
(In reply to mitz from comment #6) > > Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:177 > > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000) > > Not new to this patch, but in SPI headers we should be using the SDK version > rather than the deployment target, since the goal of the header is to > reflect the contents of an internal SDK header. That sounds exactly right to me, but I don’t understand it well enough to know exactly what to do. I would be happy to help fix it at any time, but I don’t want to risk breaking this patch by trying it as part of this one.
Comment on attachment 348716 [details] Patch Clearing flags on attachment: 348716 Committed r235585: <https://trac.webkit.org/changeset/235585>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44038929>
(In reply to WebKit Commit Bot from comment #9) > Comment on attachment 348716 [details] > Patch > > Clearing flags on attachment: 348716 > > Committed r235585: <https://trac.webkit.org/changeset/235585> Follow-up fix to remove references to WebDownloadInternal.h from the WebKitLegacy Xcode project: Committed r235663: <https://trac.webkit.org/changeset/235663>