RESOLVED FIXED 189055
[IntersectionObserver] Implement intersection logic for the same-document implicit root case 
https://bugs.webkit.org/show_bug.cgi?id=189055
Summary [IntersectionObserver] Implement intersection logic for the same-document im...
Ali Juma
Reported 2018-08-28 13:37:58 PDT
Extend the intersection logic to handle computing the intersection of the target and the viewport, for the case where the target is in the main frame.
Attachments
Patch (17.18 KB, patch)
2018-08-28 13:44 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-08-28 13:44:52 PDT
Created attachment 348336 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-28 15:17:39 PDT
Comment on attachment 348336 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348336&action=review > Source/WebCore/dom/Document.cpp:7465 > + if (!rootRenderer->isContainingBlockAncestorFor(*targetRenderer)) Shame we have to do an ancestor walk here.
WebKit Commit Bot
Comment 3 2018-08-29 05:36:21 PDT
Comment on attachment 348336 [details] Patch Clearing flags on attachment: 348336 Committed r235459: <https://trac.webkit.org/changeset/235459>
WebKit Commit Bot
Comment 4 2018-08-29 05:36:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-08-29 05:37:16 PDT
<rdar://problem/43838709>
Note You need to log in before you can comment on or make changes to this bug.