Bug 189055 - [IntersectionObserver] Implement intersection logic for the same-document implicit root case
Summary: [IntersectionObserver] Implement intersection logic for the same-document im...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
Keywords: InRadar
Depends on:
Blocks: 159475
  Show dependency treegraph
Reported: 2018-08-28 13:37 PDT by Ali Juma
Modified: 2018-08-29 05:37 PDT (History)
10 users (show)

See Also:

Patch (17.18 KB, patch)
2018-08-28 13:44 PDT, Ali Juma
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-08-28 13:37:58 PDT
Extend the intersection logic to handle computing the intersection of the target and the viewport, for the case where the target is in the main frame.
Comment 1 Ali Juma 2018-08-28 13:44:52 PDT
Created attachment 348336 [details]
Comment 2 Simon Fraser (smfr) 2018-08-28 15:17:39 PDT
Comment on attachment 348336 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=348336&action=review

> Source/WebCore/dom/Document.cpp:7465
> +        if (!rootRenderer->isContainingBlockAncestorFor(*targetRenderer))

Shame we have to do an ancestor walk here.
Comment 3 WebKit Commit Bot 2018-08-29 05:36:21 PDT
Comment on attachment 348336 [details]

Clearing flags on attachment: 348336

Committed r235459: <https://trac.webkit.org/changeset/235459>
Comment 4 WebKit Commit Bot 2018-08-29 05:36:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-29 05:37:16 PDT