Bug 189035 – [LFC][Floating] Remove redundant FloatAvoider functions.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

and move some code from FloatingContext to FloatAvoider

[zalan]

Created attachment 348239 [details]
Patch

[Antti Koivisto]

Comment on attachment 348239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348239&action=review

> Source/WebCore/layout/floats/FloatAvoider.h:64
> +    void resetHorizontalConstraint();

Some of these are singulars like here "Constraint".

> Source/WebCore/layout/floats/FloatingContext.cpp:71
> +    FloatAvoider::HorizontalConstraints horizontalConstraints() const;

And some are plural. Is there some logic to this?

[Antti Koivisto]

Comment on attachment 348239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348239&action=review

> Source/WebCore/layout/floats/FloatingContext.cpp:228
> +        floatAvoider.setHorizontalConstraints(floats.horizontalConstraints());
> +        floatAvoider.setVerticalConstraint(floats.verticalPosition());

It looks strange that the second one is reading floats.verticalPosition instead of floats.verticalConstraint. But maybe it makes sense?

[zalan]

Committed r235423: <https://trac.webkit.org/changeset/235423>

[Radar WebKit Bug Importer]

<rdar://problem/43797393>

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 348239 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348239&action=review
> 
> > Source/WebCore/layout/floats/FloatAvoider.h:64
> > +    void resetHorizontalConstraint();
> 
> Some of these are singulars like here "Constraint".
> 
> > Source/WebCore/layout/floats/FloatingContext.cpp:71
> > +    FloatAvoider::HorizontalConstraints horizontalConstraints() const;
> 
> And some are plural. Is there some logic to this?

Fixed. No logic, oversight.

[Radar WebKit Bug Importer]

<rdar://problem/43797406>

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 348239 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348239&action=review
> 
> > Source/WebCore/layout/floats/FloatingContext.cpp:228
> > +        floatAvoider.setHorizontalConstraints(floats.horizontalConstraints());
> > +        floatAvoider.setVerticalConstraint(floats.verticalPosition());
> 
> It looks strange that the second one is reading floats.verticalPosition
> instead of floats.verticalConstraint. But maybe it makes sense?
Fixed.

[Radar WebKit Bug Importer]

<rdar://problem/43797410>