189009 – Bundle unified sources more tightly in projects with deep directory structures

RESOLVED FIXED 189009

Bundle unified sources more tightly in projects with deep directory structures

https://bugs.webkit.org/show_bug.cgi?id=189009

Summary Bundle unified sources more tightly in projects with deep directory structures

Tim Horton

Reported 2018-08-27 14:48:21 PDT

Bundle unified sources more tightly in projects with deep directory structures

Attachments
Patch (33.52 KB, patch) 2018-08-27 14:49 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (57.21 KB, patch) 2018-08-27 15:23 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (57.21 KB, patch) 2018-08-27 15:25 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (60.84 KB, patch) 2018-08-27 15:26 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (58.44 KB, patch) 2018-08-27 15:28 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (50.47 KB, patch) 2018-08-27 15:30 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (53.78 KB, patch) 2018-08-27 15:48 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (54.27 KB, patch) 2018-08-27 16:04 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (54.78 KB, patch) 2018-08-27 16:24 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (54.79 KB, patch) 2018-08-27 16:29 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (54.76 KB, patch) 2018-08-27 16:45 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (53.64 KB, patch) 2018-08-27 18:02 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (54.08 KB, patch) 2018-08-27 18:22 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (55.08 KB, patch) 2018-08-27 19:03 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (55.98 KB, patch) 2018-08-27 19:26 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (56.50 KB, patch) 2018-08-27 19:27 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (57.68 KB, patch) 2018-08-27 20:40 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (58.97 KB, patch) 2018-08-27 20:58 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (59.93 KB, patch) 2018-08-27 21:28 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (60.49 KB, patch) 2018-08-27 22:42 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (61.15 KB, patch) 2018-08-28 10:53 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (61.67 KB, patch) 2018-08-28 11:32 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (62.34 KB, patch) 2018-08-28 12:45 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (63.42 KB, patch) 2018-08-29 20:03 PDT, Michael Catanzaro	no flags	Details Formatted Diff Diff
Patch (63.51 KB, patch) 2018-08-30 11:57 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (62.88 KB, patch) 2018-08-30 12:11 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (25) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2018-08-27 14:49:31 PDT

Created attachment 348203 [details] Patch

Tim Horton

Comment 2 2018-08-27 15:23:47 PDT

Created attachment 348211 [details] Patch

Tim Horton

Comment 3 2018-08-27 15:25:12 PDT

Created attachment 348212 [details] Patch

Alex Christensen

Comment 4 2018-08-27 15:25:58 PDT

Comment on attachment 348212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348212&action=review > Source/WebKit/ChangeLog:50 > +2018-08-27 Tim Horton <timothy_horton@apple.com> double change log

Tim Horton

Comment 5 2018-08-27 15:26:48 PDT

Created attachment 348213 [details] Patch

Tim Horton

Comment 6 2018-08-27 15:28:01 PDT

Created attachment 348214 [details] Patch

Tim Horton

Comment 7 2018-08-27 15:30:25 PDT

Created attachment 348215 [details] Patch

Alex Christensen

Comment 8 2018-08-27 15:35:00 PDT

Comment on attachment 348212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348212&action=review > Source/WebCore/page/AlternativeTextClient.h:-34 > -#define USE_DICTATION_ALTERNATIVES 1 There's a FIXME in WebPageProxy.h about this.

Tim Horton

Comment 9 2018-08-27 15:48:55 PDT

Created attachment 348222 [details] Patch

Tim Horton

Comment 10 2018-08-27 16:04:47 PDT

Created attachment 348228 [details] Patch

Alex Christensen

Comment 11 2018-08-27 16:07:18 PDT

r=me

Tim Horton

Comment 12 2018-08-27 16:24:12 PDT

Created attachment 348233 [details] Patch

Tim Horton

Comment 13 2018-08-27 16:29:07 PDT

Created attachment 348234 [details] Patch

Tim Horton

Comment 14 2018-08-27 16:42:34 PDT

The WPE failure is super weird.

Tim Horton

Comment 15 2018-08-27 16:45:56 PDT

Created attachment 348238 [details] Patch

Tim Horton

Comment 16 2018-08-27 18:02:50 PDT

Created attachment 348245 [details] Patch

Tim Horton

Comment 17 2018-08-27 18:22:38 PDT

Created attachment 348248 [details] Patch

Tim Horton

Comment 18 2018-08-27 19:03:05 PDT

Created attachment 348250 [details] Patch

Tim Horton

Comment 19 2018-08-27 19:26:40 PDT

Created attachment 348252 [details] Patch

Tim Horton

Comment 20 2018-08-27 19:27:54 PDT

Created attachment 348254 [details] Patch

Tim Horton

Comment 21 2018-08-27 20:40:39 PDT

Created attachment 348259 [details] Patch

Tim Horton

Comment 22 2018-08-27 20:57:57 PDT

Seems like X11 headers are super dirty (at least, have a macro `None`). So I'm de-unifying some GTK things to keep it building.

Tim Horton

Comment 23 2018-08-27 20:58:39 PDT

Created attachment 348261 [details] Patch

Tim Horton

Comment 24 2018-08-27 21:28:00 PDT

Created attachment 348263 [details] Patch

Tim Horton

Comment 25 2018-08-27 22:42:09 PDT

Created attachment 348264 [details] Patch

Michael Catanzaro

Comment 26 2018-08-28 06:06:19 PDT

(In reply to Tim Horton from comment #22) > Seems like X11 headers are super dirty (at least, have a macro `None`). So > I'm de-unifying some GTK things to keep it building. Yeah, that None's pretty infamous. :/ X11 is 80s technology, I'm afraid.

Michael Catanzaro

Comment 27 2018-08-28 06:09:38 PDT

Does this commit lead to a good build speedup? If so, then OK, but otherwise perhaps it's not worth it? It's not surprising that unifying files from different directories is harder.

Michael Catanzaro

Comment 28 2018-08-28 06:18:09 PDT

BTW, I'll try to help with the GTK and WPE builds later today or tomorrow.

Tim Horton

Comment 29 2018-08-28 08:51:11 PDT

(In reply to Michael Catanzaro from comment #27) > Does this commit lead to a good build speedup? If so, then OK, but otherwise > perhaps it's not worth it? It's not surprising that unifying files from > different directories is harder. In WebKit2 it’s quite sizable. In WebCore there’s impact but less huge. I think WPE is ok, and Gtk is clooooose.

Tim Horton

Comment 30 2018-08-28 10:40:02 PDT

(In reply to Tim Horton from comment #29) > (In reply to Michael Catanzaro from comment #27) > > Does this commit lead to a good build speedup? If so, then OK, but otherwise > > perhaps it's not worth it? It's not surprising that unifying files from > > different directories is harder. ALSO, many of these fixes are errors that have crept in since we turned on unified sources and would affect our ability to build singly, so they're good to fix regardless. > In WebKit2 it’s quite sizable. In WebCore there’s impact but less huge. > > I think WPE is ok, and Gtk is clooooose.

Tim Horton

Comment 31 2018-08-28 10:53:20 PDT

Created attachment 348311 [details] Patch

Tim Horton

Comment 32 2018-08-28 11:32:51 PDT

Created attachment 348314 [details] Patch

Tim Horton

Comment 33 2018-08-28 12:45:22 PDT

Created attachment 348324 [details] Patch

Tim Horton

Comment 34 2018-08-28 13:01:55 PDT

I'm going to give up until mcatanzaro has a chance to peek at GTK.

Michael Catanzaro

Comment 35 2018-08-28 13:56:50 PDT

OK. Right now I am attempting to figure out which of 235407-235410 (inclusive) has busted the layout tests so badly for GTK. I've never had so much trouble before. This bug is next!

Michael Catanzaro

Comment 36 2018-08-28 14:09:34 PDT

Oh, just from glancing at EWS, you busted Windows too. :P The Ruby process is crashing. Congrats! [NOTE] You may have encountered a bug in the Ruby interpreter or extension libraries. Bug reports are welcome. For details: http://www.ruby-lang.org/bugreport.html 0 [main] ruby 8204 cygwin_exception::open_stackdumpfile: Dumping stack trace to ruby.exe.stackdump CMake Error at Source/cmake/WebKitMacros.cmake:47 (message): generate-unified-source-bundles.rb exited with non-zero status, exiting Call Stack (most recent call first): Source/JavaScriptCore/CMakeLists.txt:1227 (WEBKIT_COMPUTE_SOURCES)

Tim Horton

Comment 37 2018-08-28 14:22:47 PDT

Oddly windows built fine a few patches ago.

Simon Fraser (smfr)

Comment 38 2018-08-28 15:18:44 PDT

(In reply to Michael Catanzaro from comment #35) > OK. Right now I am attempting to figure out which of 235407-235410 > (inclusive) has busted the layout tests so badly for GTK. I've never had so > much trouble before. Did I break it with https://trac.webkit.org/changeset/235408/webkit ?

Michael Catanzaro

Comment 39 2018-08-28 15:33:25 PDT

(In reply to Simon Fraser (smfr) from comment #38) > Did I break it with https://trac.webkit.org/changeset/235408/webkit ? Probably either that one or r235409... I wanted to narrow it down to the right commit, for starters. Thanks for your interest. Let's discuss in bug #189009.

Michael Catanzaro

Comment 40 2018-08-28 19:54:24 PDT

Um, I meant bug #189063. Tim, I'll be back tomorrow to try to get GTK building here.

Michael Catanzaro

Comment 41 2018-08-29 18:36:05 PDT

(In reply to Michael Catanzaro from comment #40) > Um, I meant bug #189063. > > Tim, I'll be back tomorrow to try to get GTK building here. Um, tomorrow again, sorry!

Michael Catanzaro

Comment 42 2018-08-29 20:03:17 PDT

Just kidding, tonight!

Michael Catanzaro

Comment 43 2018-08-29 20:03:41 PDT

Created attachment 348474 [details] Patch

Tim Horton

Comment 44 2018-08-30 11:57:20 PDT

Created attachment 348522 [details] Patch

Tim Horton

Comment 45 2018-08-30 11:57:36 PDT

Taking a stab at making the ruby slightly worse to not crash on windows.

Tim Horton

Comment 46 2018-08-30 12:11:40 PDT

Created attachment 348525 [details] Patch

Daniel Bates

Comment 47 2018-09-06 14:39:09 PDT

*** Bug 189370 has been marked as a duplicate of this bug. ***

Radar WebKit Bug Importer

Comment 48 2018-09-06 14:42:25 PDT

<rdar://problem/44198126>

Tim Horton

Comment 49 2018-09-06 14:43:33 PDT

https://trac.webkit.org/changeset/235521/webkit

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Tim Horton

Reported

2018-08-27 14:48 PDT

Modified

2018-09-06 14:43 PDT History

CC List

8 users Show

URL

Keywords InRadar

Duplicates (1)

189370 View as bug list

Depends on

Blocks