Bug 188998 - [Curl] Enable Proxy Authentication on WebKit.
Summary: [Curl] Enable Proxy Authentication on WebKit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-27 12:08 PDT by Basuke Suzuki
Modified: 2018-08-27 17:44 PDT (History)
6 users (show)

See Also:


Attachments
PATCH (10.51 KB, patch)
2018-08-27 12:13 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff
PATCH (4.66 KB, patch)
2018-08-27 12:57 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-08-27 12:08:04 PDT
Add support for proxy authentication to curl backend running on WebKit.
This is follow up implementation of legacy implementation : https://bugs.webkit.org/show_bug.cgi?id=185266
Comment 1 Basuke Suzuki 2018-08-27 12:13:50 PDT
Created attachment 348184 [details]
PATCH
Comment 2 Basuke Suzuki 2018-08-27 12:17:47 PDT
Comment on attachment 348184 [details]
PATCH

Wrong patch....
Comment 3 Basuke Suzuki 2018-08-27 12:57:12 PDT
Created attachment 348189 [details]
PATCH
Comment 4 Build Bot 2018-08-27 12:58:47 PDT
Attachment 348189 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:36:  "WebCookieManager.h" already included at Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:32  [build/include] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2018-08-27 17:43:51 PDT
Comment on attachment 348189 [details]
PATCH

Clearing flags on attachment: 348189

Committed r235418: <https://trac.webkit.org/changeset/235418>
Comment 6 WebKit Commit Bot 2018-08-27 17:43:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-27 17:44:20 PDT
<rdar://problem/43778867>