Bug 188993 - Null pointer deref in WidthIterator
Summary: Null pointer deref in WidthIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-27 11:17 PDT by Myles C. Maxfield
Modified: 2018-08-28 13:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2018-08-27 11:18 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (4.69 KB, patch)
2018-08-27 11:27 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.49 MB, application/zip)
2018-08-27 13:32 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-27 11:17:52 PDT
Null pointer deref in WidthIterator
Comment 1 Myles C. Maxfield 2018-08-27 11:18:20 PDT
Created attachment 348173 [details]
Patch
Comment 2 EWS Watchlist 2018-08-27 11:23:41 PDT
Attachment 348173 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Myles C. Maxfield 2018-08-27 11:27:15 PDT
Created attachment 348175 [details]
Patch
Comment 4 Myles C. Maxfield 2018-08-27 11:28:10 PDT
<rdar://problem/12639559>
Comment 5 EWS Watchlist 2018-08-27 13:32:35 PDT
Comment on attachment 348175 [details]
Patch

Attachment 348175 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8999125

New failing tests:
accessibility/smart-invert-reference.html
Comment 6 EWS Watchlist 2018-08-27 13:32:37 PDT
Created attachment 348192 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 WebKit Commit Bot 2018-08-27 17:37:23 PDT
Comment on attachment 348175 [details]
Patch

Clearing flags on attachment: 348175

Committed r235416: <https://trac.webkit.org/changeset/235416>
Comment 8 WebKit Commit Bot 2018-08-27 17:37:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Simon Fraser (smfr) 2018-08-27 19:44:25 PDT
Comment on attachment 348175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348175&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=188993

Why no radar here?
Comment 10 Myles C. Maxfield 2018-08-28 13:42:40 PDT
(In reply to Simon Fraser (smfr) from comment #9)
> Comment on attachment 348175 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348175&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=188993
> 
> Why no radar here?

Just forgot to add it. It's <rdar://problem/12639559>