Bug 188988 - Allow new vector types to work with the interactive interpreter
Summary: Allow new vector types to work with the interactive interpreter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thomas Denney
URL:
Keywords: InRadar
Depends on:
Blocks: 187735
  Show dependency treegraph
 
Reported: 2018-08-27 10:36 PDT by Thomas Denney
Modified: 2018-08-27 11:23 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2018-08-27 10:40 PDT, Thomas Denney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Denney 2018-08-27 10:36:56 PDT
Allow new vector types to work with the interactive interpreter
Comment 1 Thomas Denney 2018-08-27 10:40:07 PDT
Created attachment 348159 [details]
Patch
Comment 2 Myles C. Maxfield 2018-08-27 10:54:22 PDT
Comment on attachment 348159 [details]
Patch

The checks in _checkShaderType() seem wrong. We should fix them.
Comment 3 WebKit Commit Bot 2018-08-27 11:22:13 PDT
Comment on attachment 348159 [details]
Patch

Clearing flags on attachment: 348159

Committed r235386: <https://trac.webkit.org/changeset/235386>
Comment 4 WebKit Commit Bot 2018-08-27 11:22:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-27 11:23:19 PDT
<rdar://problem/43761725>