Bug 188985 - [Payment Request] Update payment-request web platform tests
Summary: [Payment Request] Update payment-request web platform tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-27 10:02 PDT by Andy Estes
Modified: 2018-08-28 14:31 PDT (History)
11 users (show)

See Also:


Attachments
Patch (53.83 KB, patch)
2018-08-27 10:04 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (157.64 KB, patch)
2018-08-27 10:27 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-08-27 10:02:08 PDT
[Payment Request] Update payment-request web platform tests
Comment 1 Andy Estes 2018-08-27 10:04:17 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2018-08-27 10:27:43 PDT
Created attachment 348157 [details]
Patch
Comment 3 youenn fablet 2018-08-27 11:42:21 PDT
Comment on attachment 348157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348157&action=review

> LayoutTests/imported/w3c/web-platform-tests/payment-request/idlharness.https.window-expected.txt:1
> +CONSOLE MESSAGE: line 8: ReferenceError: Can't find variable: idl_test

Are we missing some other imports in common or resources?
Comment 4 Andy Estes 2018-08-27 11:59:28 PDT
(In reply to youenn fablet from comment #3)
> Comment on attachment 348157 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348157&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/payment-request/idlharness.https.window-expected.txt:1
> > +CONSOLE MESSAGE: line 8: ReferenceError: Can't find variable: idl_test
> 
> Are we missing some other imports in common or resources?

Good question. I'll check!
Comment 5 WebKit Commit Bot 2018-08-27 12:30:42 PDT
Comment on attachment 348157 [details]
Patch

Clearing flags on attachment: 348157

Committed r235390: <https://trac.webkit.org/changeset/235390>
Comment 6 WebKit Commit Bot 2018-08-27 12:30:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-27 12:33:29 PDT
<rdar://problem/43764668>
Comment 8 Truitt Savell 2018-08-28 14:31:48 PDT
Moved test expectations from mac-wk2 to general in: https://trac.webkit.org/changeset/235441/webkit

This should stop the failures across iOS.