Bug 188959 - Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
Summary: Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 174968
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-26 20:39 PDT by Devin Rousso
Modified: 2018-08-27 10:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2018-08-26 20:41 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2018-08-27 09:29 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-08-26 20:39:16 PDT
STEPS TO REPRODUCE:
1. Open WebInspector to a page with a 2D canvas
2. Take a recording of the 2D canvas (try to find one with a few thousand actions)
3. Filter by "as" among the recording actions in the NavigationSidebar
4. Backspace the text in the filter box to just have "a"
 => Nothing appears, including no "No Filter Results"
Comment 1 Devin Rousso 2018-08-26 20:41:58 PDT
Created attachment 348115 [details]
Patch
Comment 2 Brian Burg 2018-08-27 09:24:58 PDT
Comment on attachment 348115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348115&action=review

r=me but please make it more readable

> Source/WebInspectorUI/UserInterface/Views/TreeElement.js:169
> +            this.treeOutline.soon.updateVirtualizedElements(!this._hidden && this.selected ? this : null);

Pls extract this condition out so I know what the logic is trying to compute. i.e., let focusedTreeElement = ...
Comment 3 Devin Rousso 2018-08-27 09:29:21 PDT
Created attachment 348151 [details]
Patch
Comment 4 WebKit Commit Bot 2018-08-27 09:59:48 PDT
Comment on attachment 348151 [details]
Patch

Clearing flags on attachment: 348151

Committed r235377: <https://trac.webkit.org/changeset/235377>
Comment 5 WebKit Commit Bot 2018-08-27 09:59:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-27 10:00:24 PDT
<rdar://problem/43757744>