Bug 188957 – [Attachment Support] [WK2] Images copied from Mail message view paste with the wrong file name in compose

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

The resulting file names of the _WKAttachments end up looking something like "[e-mail]".

[Radar WebKit Bug Importer]

<rdar://problem/43737715>

[Wenson Hsieh]

Created attachment 348105 [details]
Depends on webkit.org/b/188903

[Wenson Hsieh]

Created attachment 348113 [details]
Rebase on trunk

[Darin Adler]

Comment on attachment 348113 [details]
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=348113&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1334
> +    auto mainResource = adoptNS([[WebResource alloc] initWithData:markupData URL:[NSURL URLWithString:@"foo.html"] MIMEType:@"text/html" textEncodingName:@"utf-8" frameName:nil]);
> +    auto pngResource = adoptNS([[WebResource alloc] initWithData:testImageData() URL:[NSURL URLWithString:@"1.png"] MIMEType:@"image/png" textEncodingName:nil frameName:nil]);
> +    auto gifResource = adoptNS([[WebResource alloc] initWithData:testGIFData() URL:[NSURL URLWithString:@"2.gif"] MIMEType:@"image/gif" textEncodingName:nil frameName:nil]);
> +    auto archive = adoptNS([[WebArchive alloc] initWithMainResource:mainResource.get() subresources:@[ pngResource.get(), gifResource.get() ] subframeArchives:@[ ]]);

We should start using ARC for our unit tests.

[Wenson Hsieh]

Comment on attachment 348113 [details]
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=348113&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1334
>> +    auto archive = adoptNS([[WebArchive alloc] initWithMainResource:mainResource.get() subresources:@[ pngResource.get(), gifResource.get() ] subframeArchives:@[ ]]);
> 
> We should start using ARC for our unit tests.

Noted!

I suppose a good first step towards this is to add bridging casts as needed (in fact, there are several places in this file that directly cast NSStrings to CFStringRefs and vice versa). I'll be fixing these as I go, in subsequent patches.

[Wenson Hsieh]

Created attachment 348148 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 348148 [details]
Patch for landing

Clearing flags on attachment: 348148

Committed r235375: <https://trac.webkit.org/changeset/235375>