Bug 188954 – [Apple Pay] PaymentRequest.show() should reject when an unsupported ApplePayRequest version is specified

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Apple Pay] PaymentRequest.show() should reject when an unsupported ApplePayRequest version is specified

[Andy Estes]

Created attachment 348098 [details]
Patch

[Darin Adler]

Comment on attachment 348098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348098&action=review

> Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp:55
> +        return Exception { InvalidAccessError, makeString("\"", String::number(version), "\" is not a supported version.") };

We should not need the String::number here as long as we include the StringConcatenateNumbers.h header. Doing it with an explicit call to String::number makes slower, larger code so we shouldn’t do it. I realize now you are just moving this code, but consider fixing it while moving it.

[Andy Estes]

Created attachment 348106 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348106 [details]
Patch

Clearing flags on attachment: 348106

Committed r235342: <https://trac.webkit.org/changeset/235342>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43739375>

[Darin Adler]

Comment on attachment 348106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348106&action=review

> Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp:56
> +        return Exception { InvalidAccessError, makeString("\"", version, "\" is not a supported version.") };

Missed another opportunity to slightly improve the makeString call. We could use '"' instead of "\"" for the first argument and it’s possibly going to be ever so slightly more efficient.

[Andy Estes]

(In reply to Darin Adler from comment #7)
> Missed another opportunity to slightly improve the makeString call. We could
> use '"' instead of "\"" for the first argument and it’s possibly going to be
> ever so slightly more efficient.

Fixed in r235494: <https://trac.webkit.org/changeset/235494>.