Bug 188953 - XMLHTTPRequest.send for Document should have same Content-Type processing rules as String
Summary: XMLHTTPRequest.send for Document should have same Content-Type processing rul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-26 08:15 PDT by Rob Buis
Modified: 2018-08-27 06:41 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.32 KB, patch)
2018-08-26 08:23 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip)
2018-08-26 09:27 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.81 MB, application/zip)
2018-08-26 09:38 PDT, Build Bot
no flags Details
Patch (6.67 KB, patch)
2018-08-26 09:39 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.17 MB, application/zip)
2018-08-26 10:32 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews100 for mac-sierra (2.30 MB, application/zip)
2018-08-26 10:43 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (3.06 MB, application/zip)
2018-08-26 11:17 PDT, Build Bot
no flags Details
Patch (12.25 KB, patch)
2018-08-26 12:21 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (11.87 KB, patch)
2018-08-27 02:40 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (11.86 KB, patch)
2018-08-27 06:10 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2018-08-26 08:15:30 PDT
Processing rules for Content-Type has been implemented send with String as parameter, but not for Document, but both be treated the same according to the spec:
https://xhr.spec.whatwg.org/#the-send()-method
Comment 1 Rob Buis 2018-08-26 08:23:04 PDT
Created attachment 348090 [details]
Patch
Comment 2 Build Bot 2018-08-26 08:24:36 PDT
Attachment 348090 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:17:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2018-08-26 09:27:41 PDT
Comment on attachment 348090 [details]
Patch

Attachment 348090 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8988111

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm
Comment 4 Build Bot 2018-08-26 09:27:42 PDT
Created attachment 348092 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Build Bot 2018-08-26 09:38:14 PDT
Comment on attachment 348090 [details]
Patch

Attachment 348090 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8988122

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm
Comment 6 Build Bot 2018-08-26 09:38:15 PDT
Created attachment 348093 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Rob Buis 2018-08-26 09:39:37 PDT
Created attachment 348094 [details]
Patch
Comment 8 Build Bot 2018-08-26 10:31:58 PDT
Comment on attachment 348094 [details]
Patch

Attachment 348094 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8988439

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm
Comment 9 Build Bot 2018-08-26 10:32:00 PDT
Created attachment 348095 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 10 Build Bot 2018-08-26 10:43:35 PDT
Comment on attachment 348094 [details]
Patch

Attachment 348094 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8988517

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm
Comment 11 Build Bot 2018-08-26 10:43:36 PDT
Created attachment 348096 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 Build Bot 2018-08-26 11:17:06 PDT
Comment on attachment 348094 [details]
Patch

Attachment 348094 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8988545

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm
Comment 13 Build Bot 2018-08-26 11:17:07 PDT
Created attachment 348097 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 14 Rob Buis 2018-08-26 12:21:20 PDT
Created attachment 348099 [details]
Patch
Comment 15 Rob Buis 2018-08-26 13:30:59 PDT
Comment on attachment 348099 [details]
Patch

Similar patch for chromium here:
https://chromium-review.googlesource.com/c/chromium/src/+/1189602
Comment 16 Rob Buis 2018-08-27 02:40:19 PDT
Created attachment 348129 [details]
Patch
Comment 17 WebKit Commit Bot 2018-08-27 05:58:33 PDT
Comment on attachment 348129 [details]
Patch

Rejecting attachment 348129 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 348129, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/8994316
Comment 18 Rob Buis 2018-08-27 06:10:36 PDT
Created attachment 348135 [details]
Patch
Comment 19 WebKit Commit Bot 2018-08-27 06:40:51 PDT
Comment on attachment 348135 [details]
Patch

Clearing flags on attachment: 348135

Committed r235360: <https://trac.webkit.org/changeset/235360>
Comment 20 WebKit Commit Bot 2018-08-27 06:40:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 21 Radar WebKit Bug Importer 2018-08-27 06:41:23 PDT
<rdar://problem/43752581>