RESOLVED FIXED 188952
output of toString() of Generator is wrong 
https://bugs.webkit.org/show_bug.cgi?id=188952
Summary output of toString() of Generator is wrong
sunlili
Reported 2018-08-26 00:30:00 PDT
Executing following code : -------------------------------------- var f = function* () {} print(f.toString()); -------------------------------------- Output of JavaScriptCore is : function () {} However, the output should be : function* () {} BT group 2018.08.26
Attachments
Patch (11.48 KB, patch)
2018-08-30 11:09 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-08-30 11:09:56 PDT
Created attachment 348511 [details] Patch
Saam Barati
Comment 2 2018-08-30 11:12:02 PDT
Comment on attachment 348511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348511&action=review r=me > Source/JavaScriptCore/runtime/FunctionPrototype.cpp:136 > + case SourceParseMode::AsyncGeneratorWrapperMethodMode: Shouldn't this async generator method be "async* " since that's the syntax?
Yusuke Suzuki
Comment 3 2018-08-30 12:04:13 PDT
Comment on attachment 348511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348511&action=review Thanks! >> Source/JavaScriptCore/runtime/FunctionPrototype.cpp:136 >> + case SourceParseMode::AsyncGeneratorWrapperMethodMode: > > Shouldn't this async generator method be "async* " since that's the syntax? Right now, we always emit `async function* ...` even for async generator methods, as we emit `function xxx() { }` for methods. When https://tc39.github.io/Function-prototype-toString-revision/ is integrated into JSC, we should revisit these cases.
Yusuke Suzuki
Comment 4 2018-08-30 12:06:27 PDT
Landed in https://trac.webkit.org/changeset/235514/webkit
Radar WebKit Bug Importer
Comment 5 2018-08-31 08:56:34 PDT
<rdar://problem/43941925>
Note You need to log in before you can comment on or make changes to this bug.