Bug 188950 - CSS reference filter that references a tiled feTurbulence is blank
Summary: CSS reference filter that references a tiled feTurbulence is blank
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: https://codepen.io/yoksel/pen/BOjmqj?...
Keywords: InRadar
Depends on: 189248
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-25 20:40 PDT by Simon Fraser (smfr)
Modified: 2018-09-05 08:10 PDT (History)
6 users (show)

See Also:

Attachments
Reduction (581 bytes, text/html)
2018-08-31 20:45 PDT, Simon Fraser (smfr) 		no flags Details
Patch (16.72 KB, patch)
2018-09-03 22:16 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (16.71 KB, patch)
2018-09-04 13:51 PDT, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
Patch (16.75 KB, patch)
2018-09-04 14:44 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-08-25 20:40:46 PDT 
https://codepen.io/yoksel/pen/BOjmqj?editors=1000 shows blank in WebKit (macOS and iOS). It works in Firefox.
Comment 1 Radar WebKit Bug Importer 2018-08-25 20:41:13 PDT 
<rdar://problem/43724286>
Comment 2 Simon Fraser (smfr) 2018-08-28 21:02:10 PDT 
In debug builds we assert:

ASSERTION FAILED: tileWidth > 0 && tileHeight > 0
./platform/graphics/filters/FETurbulence.cpp(188) : FETurbulence::StitchData WebCore::FETurbulence::computeStitching(WebCore::IntSize, float &, float &) const
1   0x116495479 WTFCrash
2   0x105b0fe4b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x1088fd976 WebCore::FETurbulence::computeStitching(WebCore::IntSize, float&, float&) const
4   0x1088ff138 WebCore::FETurbulence::platformApplySoftware()
5   0x1089005a4 WebCore::FilterEffect::apply()
Comment 3 Simon Fraser (smfr) 2018-08-28 21:05:37 PDT 
If we early return to avoid the assertion, the content renders, but the turbulence seems to have the wrong resolution on Retina displays.
Comment 4 Simon Fraser (smfr) 2018-08-31 20:45:41 PDT 
Created attachment 348704 [details]
Reduction

Seems related to stitchTiles="stitch" on feTurbulence
Comment 5 Simon Fraser (smfr) 2018-08-31 21:02:18 PDT 
tile size is computed from filterPrimitiveSubregion, which we never compute for CSS filters.
Comment 6 Simon Fraser (smfr) 2018-09-03 22:16:45 PDT Comment hidden (obsolete)
Comment 7 Simon Fraser (smfr) 2018-09-03 22:17:04 PDT Comment hidden (obsolete)
Comment 8 Simon Fraser (smfr) 2018-09-04 13:51:42 PDT 
Created attachment 348844 [details]
Patch
Comment 9 Simon Fraser (smfr) 2018-09-04 14:44:13 PDT 
Created attachment 348848 [details]
Patch
Comment 10 WebKit Commit Bot 2018-09-04 15:51:54 PDT 
Comment on attachment 348848 [details]
Patch

Clearing flags on attachment: 348848

Committed r235644: <https://trac.webkit.org/changeset/235644>