Bug 188944 - Shrink size of XMLHttpRequest
Summary: Shrink size of XMLHttpRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-25 06:34 PDT by Yusuke Suzuki
Modified: 2018-08-30 03:24 PDT (History)
10 users (show)

See Also:

Attachments
Patch (22.29 KB, patch)
2018-08-25 06:35 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-08-25 06:34:31 PDT 
Shrink size of XMLHttpRequest
Comment 1 Yusuke Suzuki 2018-08-25 06:35:59 PDT 
Created attachment 348076 [details]
Patch
Comment 2 Yusuke Suzuki 2018-08-27 01:31:04 PDT 
Committed r235355: <https://trac.webkit.org/changeset/235355>
Comment 3 Radar WebKit Bug Importer 2018-08-27 01:33:31 PDT 
<rdar://problem/43746199>
Comment 4 Simon Fraser (smfr) 2018-08-27 09:27:22 PDT 
Comment on attachment 348076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348076&action=review

> Source/WebCore/xml/XMLHttpRequest.h:203
> +    unsigned m_readyState : 3;
> +    unsigned m_responseType : 3;

In cases like this I like to see a comment documenting the enum name.
Comment 5 Yusuke Suzuki 2018-08-27 09:32:02 PDT 
Comment on attachment 348076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348076&action=review

>> Source/WebCore/xml/XMLHttpRequest.h:203
>> +    unsigned m_responseType : 3;
> 
> In cases like this I like to see a comment documenting the enum name.

Sounds good! I've added this.
Comment 6 Yusuke Suzuki 2018-08-30 03:24:21 PDT 
Committed r235498: <https://trac.webkit.org/changeset/235498>