Bug 188932 - Improve unified source generator script logging and error messages
Summary: Improve unified source generator script logging and error messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-24 14:44 PDT by Tim Horton
Modified: 2018-08-24 15:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2018-08-24 14:44 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-08-24 14:44:01 PDT 
Improve unified source generator script logging and error messages
Comment 1 Tim Horton 2018-08-24 14:44:48 PDT 
Created attachment 348040 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-08-24 15:44:54 PDT 
Comment on attachment 348040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348040&action=review

> Source/WTF/ChangeLog:8
> +        * Scripts/generate-unified-source-bundles.rb:

Why isn't this in Tools/Scripts?

> Source/WTF/Scripts/generate-unified-source-bundles.rb:306
> +# Add trailing semicolon since CMake dislikes not having it.

Maybe just # Add trailing semicolon for CMake
Comment 3 Tim Horton 2018-08-24 15:48:27 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 348040 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348040&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        * Scripts/generate-unified-source-bundles.rb:
> 
> Why isn't this in Tools/Scripts?

Scripts that are used at build time can't be in Tools/Scripts because that's not available for Apple production builds (because each Source/ subdirectory is built separately and without access to the others).

> > Source/WTF/Scripts/generate-unified-source-bundles.rb:306
> > +# Add trailing semicolon since CMake dislikes not having it.
> 
> Maybe just # Add trailing semicolon for CMake

Sure.
Comment 4 Tim Horton 2018-08-24 15:54:43 PDT 
https://trac.webkit.org/changeset/235336/webkit
Comment 5 Radar WebKit Bug Importer 2018-08-24 15:55:18 PDT 
<rdar://problem/43700805>