RESOLVED FIXED 188932
Improve unified source generator script logging and error messages 
https://bugs.webkit.org/show_bug.cgi?id=188932
Summary Improve unified source generator script logging and error messages
Tim Horton
Reported 2018-08-24 14:44:01 PDT
Improve unified source generator script logging and error messages
Attachments
Patch (6.21 KB, patch)
2018-08-24 14:44 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-08-24 14:44:48 PDT
Created attachment 348040 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-24 15:44:54 PDT
Comment on attachment 348040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348040&action=review > Source/WTF/ChangeLog:8 > + * Scripts/generate-unified-source-bundles.rb: Why isn't this in Tools/Scripts? > Source/WTF/Scripts/generate-unified-source-bundles.rb:306 > +# Add trailing semicolon since CMake dislikes not having it. Maybe just # Add trailing semicolon for CMake
Tim Horton
Comment 3 2018-08-24 15:48:27 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 348040 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348040&action=review > > > Source/WTF/ChangeLog:8 > > + * Scripts/generate-unified-source-bundles.rb: > > Why isn't this in Tools/Scripts? Scripts that are used at build time can't be in Tools/Scripts because that's not available for Apple production builds (because each Source/ subdirectory is built separately and without access to the others). > > Source/WTF/Scripts/generate-unified-source-bundles.rb:306 > > +# Add trailing semicolon since CMake dislikes not having it. > > Maybe just # Add trailing semicolon for CMake Sure.
Tim Horton
Comment 4 2018-08-24 15:54:43 PDT
https://trac.webkit.org/changeset/235336/webkit
Radar WebKit Bug Importer
Comment 5 2018-08-24 15:55:18 PDT
<rdar://problem/43700805>
Note You need to log in before you can comment on or make changes to this bug.