RESOLVED FIXED188928
YARR: Update UCS canonicalization tables for Unicode 11 
https://bugs.webkit.org/show_bug.cgi?id=188928
Summary YARR: Update UCS canonicalization tables for Unicode 11
Michael Saboff
Reported 2018-08-24 13:30:12 PDT
The generated Yarr file YarrCanonicalizeUCS2.cpp haven't been updated for over 2 years. They need to be updated for Unicode 11.
Attachments
Patch (11.33 KB, patch)
2018-08-24 13:39 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2018-08-24 13:39:29 PDT
Created attachment 348036 [details] Patch
EWS Watchlist
Comment 2 2018-08-24 13:41:29 PDT
Attachment 348036 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/yarr/YarrCanonicalizeUCS2.cpp:57: UCS2_CANONICALIZATION_SETS is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/yarr/YarrCanonicalizeUCS2.cpp:84: UCS2_CANONICALIZATION_RANGES is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2018-08-24 13:43:15 PDT
Comment on attachment 348036 [details] Patch rs=me.
WebKit Commit Bot
Comment 4 2018-08-24 14:15:08 PDT
Comment on attachment 348036 [details] Patch Clearing flags on attachment: 348036 Committed r235333: <https://trac.webkit.org/changeset/235333>
WebKit Commit Bot
Comment 5 2018-08-24 14:15:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-24 14:16:16 PDT
<rdar://problem/43696830>
Note You need to log in before you can comment on or make changes to this bug.