Bug 188923 - Introduce _WKInspector
Summary: Introduce _WKInspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-24 11:18 PDT by Alex Christensen
Modified: 2018-08-24 12:10 PDT (History)
2 users (show)

See Also:


Attachments
Patch (20.16 KB, patch)
2018-08-24 11:19 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (20.15 KB, patch)
2018-08-24 11:24 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-24 11:18:04 PDT
Introduce _WKInspector
Comment 1 Alex Christensen 2018-08-24 11:19:05 PDT
Created attachment 348025 [details]
Patch
Comment 2 Alex Christensen 2018-08-24 11:24:00 PDT
Created attachment 348026 [details]
Patch
Comment 3 Alex Christensen 2018-08-24 11:33:03 PDT
rdar://problem/34657861
Comment 4 BJ Burg 2018-08-24 11:37:02 PDT
Comment on attachment 348026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348026&action=review

r=me, yay!

> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:135
> +    [[self webView] evaluateJavaScript:[NSString stringWithFormat:@"console.error(\"%@\");", error] completionHandler:nil];

Nit: self.webView, maybe
Comment 5 Alex Christensen 2018-08-24 11:42:07 PDT
https://trac.webkit.org/changeset/235323/webkit
Comment 6 Alex Christensen 2018-08-24 12:10:32 PDT
http://trac.webkit.org/r235324