RESOLVED FIXED188922
[Curl] Match the interface used in NetworkDataTask and ResourceHandle. 
https://bugs.webkit.org/show_bug.cgi?id=188922
Summary [Curl] Match the interface used in NetworkDataTask and ResourceHandle.
Basuke Suzuki
Reported 2018-08-24 11:10:23 PDT
Both uses different set of enum for same meaning.
Attachments
PATCH (4.68 KB, patch)
2018-08-24 11:29 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-08-24 11:29:42 PDT
Created attachment 348028 [details] PATCH
Basuke Suzuki
Comment 2 2018-08-24 11:31:11 PDT
Comment on attachment 348028 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=348028&action=review > Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h:54 > + ReusedRequest This enum class is the one used in ResourceHandle. This one is more meaningful than ShouldProcess which is just a boolean equivalent.
Alex Christensen
Comment 3 2018-08-24 11:37:32 PDT
Comment on attachment 348028 [details] PATCH This is nice. I think it would be even nicer to remove this new/reused nonsense unless there is a measurable performance improvement to make the code complexity and risk of forgetting to update things worth it.
Basuke Suzuki
Comment 4 2018-08-24 11:48:23 PDT
Comment on attachment 348028 [details] PATCH Thanks for r+. We think about removing this flag. I remember this relate to not only cookie, but diskcache on ResourceHandle.
WebKit Commit Bot
Comment 5 2018-08-24 12:14:43 PDT
Comment on attachment 348028 [details] PATCH Clearing flags on attachment: 348028 Committed r235326: <https://trac.webkit.org/changeset/235326>
WebKit Commit Bot
Comment 6 2018-08-24 12:14:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-24 12:15:16 PDT
<rdar://problem/43693070>
Note You need to log in before you can comment on or make changes to this bug.