Bug 188922 - [Curl] Match the interface used in NetworkDataTask and ResourceHandle.
Summary: [Curl] Match the interface used in NetworkDataTask and ResourceHandle.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-24 11:10 PDT by Basuke Suzuki
Modified: 2018-08-24 12:15 PDT (History)
4 users (show)

See Also:

Attachments
PATCH (4.68 KB, patch)
2018-08-24 11:29 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-08-24 11:10:23 PDT 
Both uses different set of enum for same meaning.
Comment 1 Basuke Suzuki 2018-08-24 11:29:42 PDT 
Created attachment 348028 [details]
PATCH
Comment 2 Basuke Suzuki 2018-08-24 11:31:11 PDT 
Comment on attachment 348028 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=348028&action=review

> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h:54
> +        ReusedRequest

This enum class is the one used in ResourceHandle. This one is more meaningful than ShouldProcess which is just a boolean equivalent.
Comment 3 Alex Christensen 2018-08-24 11:37:32 PDT 
Comment on attachment 348028 [details]
PATCH

This is nice.  I think it would be even nicer to remove this new/reused nonsense unless there is a measurable performance improvement to make the code complexity and risk of forgetting to update things worth it.
Comment 4 Basuke Suzuki 2018-08-24 11:48:23 PDT 
Comment on attachment 348028 [details]
PATCH

Thanks for r+. We think about removing this flag. I remember this relate to not only cookie, but diskcache on ResourceHandle.
Comment 5 WebKit Commit Bot 2018-08-24 12:14:43 PDT 
Comment on attachment 348028 [details]
PATCH

Clearing flags on attachment: 348028

Committed r235326: <https://trac.webkit.org/changeset/235326>
Comment 6 WebKit Commit Bot 2018-08-24 12:14:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-24 12:15:16 PDT 
<rdar://problem/43693070>