Bug 188919 – [FreeType] Do not cast through GLib types in FontCustomPlatformDataFreeType.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Adrian Perez]

As por Don's comment in bug #185462 (comment 8)

> Noticed this issue while rebasing. GCallback shouldn't be in freetype files.
>
> > Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:51
> > +        reinterpret_cast<cairo_destroy_func_t>(reinterpret_cast<GCallback>(FT_Done_Face)));
>
> This casts assumes USE(GLIB)

[Adrian Perez]

Created attachment 348003 [details]
Patch

[Michael Catanzaro]

Comment on attachment 348003 [details]
Patch

The double cast is probably needed to silence -Wcast-function-type. Are you certain this doesn't introduce any new warnings when building with GCC 8?

Instead of casting through GCallback, you can instead cast through void (*) (void). That's the documented way to avoid -Wcast-function-type. GCallback is just a typedef for that.

[Michael Catanzaro]

Comment on attachment 348003 [details]
Patch

This blames to r231565

So you'll need to use void (*) (void) instead.

[Adrian Perez]

Created attachment 348005 [details]
Patch

[Don Olmstead]

Clang is happy with the change. So informally I would r+ this as long as GCC is happy.

[WebKit Commit Bot]

Comment on attachment 348005 [details]
Patch

Clearing flags on attachment: 348005

Committed r235325: <https://trac.webkit.org/changeset/235325>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43693002>