Bug 188912 - [LFC][Floating] Simplify FloatingState::FloatItem class
Summary: [LFC][Floating] Simplify FloatingState::FloatItem class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-23 19:09 PDT by zalan
Modified: 2018-08-26 21:04 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.82 KB, patch)
2018-08-23 19:19 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-23 19:09:28 PDT 
now that we've got a dedicated class for incoming floats.
Comment 1 zalan 2018-08-23 19:19:18 PDT 
Created attachment 347984 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-08-24 10:37:07 PDT 
Comment on attachment 347984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347984&action=review

> Source/WebCore/layout/floats/FloatingContext.cpp:68
> +    const FloatingState::FloatItem* left() const;
> +    const FloatingState::FloatItem* right() const;

"FloatItem" is a weird name. "Item" doesn't tell me what type it is, and we don't use "item" in other rendering code.
Comment 3 zalan 2018-08-24 11:21:19 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 347984 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347984&action=review
> 
> > Source/WebCore/layout/floats/FloatingContext.cpp:68
> > +    const FloatingState::FloatItem* left() const;
> > +    const FloatingState::FloatItem* right() const;
> 
> "FloatItem" is a weird name. "Item" doesn't tell me what type it is, and we
> don't use "item" in other rendering code.
I am planning to rename it in an upcoming patch.
Comment 4 zalan 2018-08-26 21:03:31 PDT 
Committed r235350: <https://trac.webkit.org/changeset/235350>
Comment 5 Radar WebKit Bug Importer 2018-08-26 21:04:17 PDT 
<rdar://problem/43741775>