RESOLVED FIXED188912
[LFC][Floating] Simplify FloatingState::FloatItem class 
https://bugs.webkit.org/show_bug.cgi?id=188912
Summary [LFC][Floating] Simplify FloatingState::FloatItem class
alan
Reported 2018-08-23 19:09:28 PDT
now that we've got a dedicated class for incoming floats.
Attachments
Patch (12.82 KB, patch)
2018-08-23 19:19 PDT, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-08-23 19:19:18 PDT
Created attachment 347984 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-24 10:37:07 PDT
Comment on attachment 347984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347984&action=review > Source/WebCore/layout/floats/FloatingContext.cpp:68 > + const FloatingState::FloatItem* left() const; > + const FloatingState::FloatItem* right() const; "FloatItem" is a weird name. "Item" doesn't tell me what type it is, and we don't use "item" in other rendering code.
alan
Comment 3 2018-08-24 11:21:19 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 347984 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347984&action=review > > > Source/WebCore/layout/floats/FloatingContext.cpp:68 > > + const FloatingState::FloatItem* left() const; > > + const FloatingState::FloatItem* right() const; > > "FloatItem" is a weird name. "Item" doesn't tell me what type it is, and we > don't use "item" in other rendering code. I am planning to rename it in an upcoming patch.
alan
Comment 4 2018-08-26 21:03:31 PDT
Committed r235350: <https://trac.webkit.org/changeset/235350>
Radar WebKit Bug Importer
Comment 5 2018-08-26 21:04:17 PDT
<rdar://problem/43741775>
Note You need to log in before you can comment on or make changes to this bug.